Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding Header Commands To The Download CLI phase#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 6 commits intocoder:mainfromliorb-canva:main
Nov 2, 2023

Conversation

liorb-canva
Copy link
Contributor

Background:

The login phase of the JetBrains Coder plugin involves downloading a fresh CLI binary from the control plane. However, if the control plane is located behind a VPN or protected by Cloudflare, it requires passing relevant tokens to the download request to ensure a successful download. To handle this, JetBrains Coder introduces the concept of "header commands" as a means of adding these tokens.

Changes Made:

This pull request addresses the need to support header commands by utilizing them when downloading the CLI binary

What's Included:

  1. Added Support for Header Commands: This PR includes the necessary changes to enable the use of header commands during the CLI binary download process.

Why This Matters:

Enabling header commands support for CLI binary downloads is crucial for ensuring the seamless operation of the JetBrains Coder plugin in environments where the control plane is protected by VPN or Cloudflare. This enhancement will improve the reliability and functionality of the plugin in such scenarios.

How to Verify:

  • Deploy the plugin with these changes.
  • Attempt to log in to the JetBrains Coder plugin in an environment behind a VPN or protected by Cloudflare.
  • Verify that the CLI binary download successfully uses the header commands to pass the required tokens.

Thank you for your time and consideration! 🙌

@liorb-canvaliorb-canva changed the title🚀 GitHub PR Description: Adding Header Commands To The Download CLI phaseAdding Header Commands To The Download CLI phaseNov 2, 2023
Copy link
Collaborator

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

some suggestions & comments inline

liorb-canvaand others added2 commitsNovember 2, 2023 18:58
Co-authored-by: Spike Curtis <spike@spikecurtis.com>
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

For good measure, I'd like to seeCODER_HEADER supported as well. However, that's not implemented in the settings, so feel free to disregard this comment.

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for fixing this! Was a big miss.

liorb-canva reacted with hooray emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri left review comments

@code-ashercode-ashercode-asher approved these changes

@johnstcnjohnstcnAwaiting requested review from johnstcn

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@liorb-canva@mafredri@spikecurtis@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp