- Notifications
You must be signed in to change notification settings - Fork16
Adding Header Commands To The Download CLI phase#323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
some suggestions & comments inline
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Spike Curtis <spike@spikecurtis.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
For good measure, I'd like to seeCODER_HEADER
supported as well. However, that's not implemented in the settings, so feel free to disregard this comment.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for fixing this! Was a big miss.
Background:
The login phase of the JetBrains Coder plugin involves downloading a fresh CLI binary from the control plane. However, if the control plane is located behind a VPN or protected by Cloudflare, it requires passing relevant tokens to the download request to ensure a successful download. To handle this, JetBrains Coder introduces the concept of "header commands" as a means of adding these tokens.
Changes Made:
This pull request addresses the need to support header commands by utilizing them when downloading the CLI binary
What's Included:
Why This Matters:
Enabling header commands support for CLI binary downloads is crucial for ensuring the seamless operation of the JetBrains Coder plugin in environments where the control plane is protected by VPN or Cloudflare. This enhancement will improve the reliability and functionality of the plugin in such scenarios.
How to Verify:
Thank you for your time and consideration! 🙌