- Notifications
You must be signed in to change notification settings - Fork16
chore: minor cleanup PR#315#322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (settings.tlsCertPath.isBlank() || settings.tlsKeyPath.isBlank()) { | ||
| return SSLSocketFactory.getDefault() as SSLSocketFactory | ||
| } | ||
| fun SSLContextFromPEMs(certPath: String, keyPath: String, caPath: String) : SSLContext { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just refactored this out ofcoderSocketFactory so we could reuse the pem parsing logic for the SSL context for the tests.
* use trust store for ssl connections even if key/cert not used.* remove/fix debugging println* fix property names to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is awesome, thank you!!
@code-asher I think this addresses your PR comments from#315