Movatterモバイル変換

Skip to content

coder/jetbrains-coderPublic

NotificationsYou must be signed in to change notification settings
Fork16
Star34

Commit71086c9

code-asher

authored

Remove HostName from SSH config (#336)

It is not necessary because the proxy command is what is in control hereand having HostName causes errors in Gateway about the host not beingfound even though it seems to work in the end.

1 parenta1c965f commit71086c9Copy full SHA for 71086c9

File tree

15 files changed

+0

-16

lines changed

src
- main/kotlin/com/coder/gateway/sdk
  - CoderCLIManager.kt
- test/fixtures/outputs

15 files changed

+0

-16

lines changed

`‎src/main/kotlin/com/coder/gateway/sdk/CoderCLIManager.kt‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,6 @@ class CoderCLIManager @JvmOverloads constructor(`
`234`	`234`	`transform= {`
`235`	`235`	`"""`
`236`	`236`	`Host${getHostName(deploymentURL, it)}`
`237`		`- HostName coder.${it.name}`
`238`	`237`	`ProxyCommand${proxyArgs.joinToString("")}${it.name}`
`239`	`238`	`ConnectTimeout 0`
`240`	`239`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/append-blank-newlines.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`
`5`	`5`	`# --- START CODER JETBRAINS test.coder.invalid`
`6`	`6`	`Host coder-jetbrains--foo-bar--test.coder.invalid`
`7`		`- HostName coder.foo-bar`
`8`	`7`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo-bar`
`9`	`8`	`ConnectTimeout 0`
`10`	`9`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/append-blank.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`# --- START CODER JETBRAINS test.coder.invalid`
`2`	`2`	`Host coder-jetbrains--foo-bar--test.coder.invalid`
`3`		`- HostName coder.foo-bar`
`4`	`3`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo-bar`
`5`	`4`	`ConnectTimeout 0`
`6`	`5`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/append-no-blocks.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ Host test2`
`5`	`5`
`6`	`6`	`# --- START CODER JETBRAINS test.coder.invalid`
`7`	`7`	`Host coder-jetbrains--foo-bar--test.coder.invalid`
`8`		`- HostName coder.foo-bar`
`9`	`8`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo-bar`
`10`	`9`	`ConnectTimeout 0`
`11`	`10`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/append-no-newline.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@ Host test2`
`4`	`4`	`Port 443`
`5`	`5`	`# --- START CODER JETBRAINS test.coder.invalid`
`6`	`6`	`Host coder-jetbrains--foo-bar--test.coder.invalid`
`7`		`- HostName coder.foo-bar`
`8`	`7`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo-bar`
`9`	`8`	`ConnectTimeout 0`
`10`	`9`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/append-no-related-blocks.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ some jetbrains config`
`11`	`11`
`12`	`12`	`# --- START CODER JETBRAINS test.coder.invalid`
`13`	`13`	`Host coder-jetbrains--foo-bar--test.coder.invalid`
`14`		`- HostName coder.foo-bar`
`15`	`14`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo-bar`
`16`	`15`	`ConnectTimeout 0`
`17`	`16`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/header-command-windows.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`# --- START CODER JETBRAINS test.coder.invalid`
`2`	`2`	`Host coder-jetbrains--header--test.coder.invalid`
`3`		`- HostName coder.header`
`4`	`3`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config --header-command "C:\Program Files\My Header Command\\"also has quotes\"\HeaderCommand.exe" ssh --stdio header`
`5`	`4`	`ConnectTimeout 0`
`6`	`5`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/header-command.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`# --- START CODER JETBRAINS test.coder.invalid`
`2`	`2`	`Host coder-jetbrains--header--test.coder.invalid`
`3`		`- HostName coder.header`
`4`	`3`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config --header-command "my-header-command \"test\"" ssh --stdio header`
`5`	`4`	`ConnectTimeout 0`
`6`	`5`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/multiple-workspaces.conf‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,12 @@`
`1`	`1`	`# --- START CODER JETBRAINS test.coder.invalid`
`2`	`2`	`Host coder-jetbrains--foo--test.coder.invalid`
`3`		`- HostName coder.foo`
`4`	`3`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo`
`5`	`4`	`ConnectTimeout 0`
`6`	`5`	`StrictHostKeyChecking no`
`7`	`6`	`UserKnownHostsFile /dev/null`
`8`	`7`	`LogLevel ERROR`
`9`	`8`	`SetEnv CODER_SSH_SESSION_TYPE=JetBrains`
`10`	`9`	`Host coder-jetbrains--bar--test.coder.invalid`
`11`		`- HostName coder.bar`
`12`	`10`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio bar`
`13`	`11`	`ConnectTimeout 0`
`14`	`12`	`StrictHostKeyChecking no`

`‎src/test/fixtures/outputs/replace-end-no-newline.conf‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ Host test`
`3`	`3`	`Host test2`
`4`	`4`	`Port 443 # --- START CODER JETBRAINS test.coder.invalid`
`5`	`5`	`Host coder-jetbrains--foo-bar--test.coder.invalid`
`6`		`- HostName coder.foo-bar`
`7`	`6`	`ProxyCommand /tmp/coder-gateway/test.coder.invalid/coder-linux-amd64 --global-config /tmp/coder-gateway/test.coder.invalid/config ssh --stdio foo-bar`
`8`	`7`	`ConnectTimeout 0`
`9`	`8`	`StrictHostKeyChecking no`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp