Commit565fd78

committed

fix: escape ampersand and question mark in ProxyCommand

Fixes#479.

1 parent16b9788 commit565fd78Copy full SHA for 565fd78

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,10 @@ fun escape(s: String): String {`
`12`	`12`	`if (s.contains("\n")) {`
`13`	`13`	`throwException("argument cannot contain newlines")`
`14`	`14`	`}`
`15`		`-if (s.contains("")\|\| s.contains("\t")) {`
`16`		`-return"\""+ s.replace("\"","\\\"")+"\""`
	`15`	`+if (s.contains("")\|\| s.contains("\t")\|\| s.contains("&")\|\| s.contains("?")) {`
	`16`	`+// See https://github.com/coder/jetbrains-coder/issues/479`
	`17`	`+// Escape existing " and &`
	`18`	`+return"\""+ s.replace("\"","\\\"").replace("&","\\&").replace("?","\\?")+"\""`
`17`	`19`	`}`
`18`	`20`	`return s.replace("\"","\\\"")`
`19`	`21`	`}`

Comments

(0)