Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

coder 2.1.4#96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 9 commits intotap-refreshfromcoder-v2
Aug 29, 2023
Merged

coder 2.1.4#96

aslilac merged 9 commits intotap-refreshfromcoder-v2
Aug 29, 2023

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedAug 29, 2023
edited
Loading

  • Rename old formulae to all point at "coder@1" (since they've been identical for a long time anyway)
  • Refactor coder@1 formula to simplify version updating
  • Introduce new coder formula for installing full v2 binaries
  • Add a script for updating the coder formula
  • Setup tests to use the "official" brew testing pattern
    • Includes all the nice things you'd expect like code formatting, hash validation, running brew tests, etc.

@aslilacaslilac marked this pull request as ready for reviewAugust 29, 2023 18:11
@aslilacaslilac requested a review frombpmctAugust 29, 2023 18:11
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, Just to clarify with the renaming, anyone with the old CLI installed will keep the old CLI installed until they uninstall and install the new one?

Comment on lines +15 to +16
url "https://github.com/coder/coder/releases/download/v#{version}/coder_#{version}_linux_amd64.tar.gz"
sha256 "41666bbe3afacd153fbe6c1a2d908bb4fb7a88e821205cb7136a0bad2d1cd6dc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We havearmv7,arm64 andamd64 for Linux so it'd be nice to do the Hardware::CPU checks for those too.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Homebrew only supports x64 linux, unfortunately. It won't install or run on anything else. :\ If they ever add that platform support tho, we should 100% match it.

@aslilac
Copy link
MemberAuthor

Just to clarify with the renaming, anyone with the old CLI installed will keep the old CLI installed until they uninstall and install the new one?

Correct. The way Homebrew handles this internally is actually super clever. :)

@aslilacaslilac merged commit508bff6 intotap-refreshAug 29, 2023
@aslilacaslilac deleted the coder-v2 branchAugust 29, 2023 19:09
@aslilacaslilac restored the coder-v2 branchAugust 29, 2023 19:10
@aslilacaslilac mentioned this pull requestAug 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp