Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: broken implementation and tests#8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 5 commits intomainfromdm-fix-broken-stuff
Apr 16, 2025

Conversation

DanielleMaywood
Copy link
Collaborator

Unfortunately it appears I didn't manually test well enough. I've now fixed how the arguments are forwarded to thecode-server CLI. I've also fixed any tests that broke due to the change.

@DanielleMaywoodDanielleMaywood self-assigned thisApr 15, 2025
Unfortunately it appears I didn't manually test well enough. I've nowfixed how the arguments are forwarded to the `code-server` CLI. I'vealso fixed any tests that broke due to the change.
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (9)
  • src/code-server/install.sh: Language not supported
  • test/code-server/code-server-auth-none.sh: Language not supported
  • test/code-server/code-server-auth-password.sh: Language not supported
  • test/code-server/code-server-cert.sh: Language not supported
  • test/code-server/code-server-cert/Dockerfile: Language not supported
  • test/code-server/code-server-socket-with-mode.sh: Language not supported
  • test/code-server/code-server-socket.sh: Language not supported
  • test/code-server/code-server-workspace.sh: Language not supported
  • test/code-server/scenarios.json: Language not supported

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewApril 15, 2025 12:06
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left a few suggestions, lmk what you think.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! Had a minor suggestion still but otherwise good to go 👍🏻

@DanielleMaywoodDanielleMaywood merged commit4384a34 intomainApr 16, 2025
8 checks passed
@DanielleMaywoodDanielleMaywood deleted the dm-fix-broken-stuff branchApril 16, 2025 09:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DanielleMaywood@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp