Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add--cert* options#6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 2 commits intomainfromdm-add-cert-options
Apr 14, 2025
Merged

Conversation

DanielleMaywood
Copy link
Collaborator

@DanielleMaywoodDanielleMaywood commentedApr 14, 2025•
edited
Loading

Add new configuration options for custom SSL certificates:

  • cert: Path to certificate
  • certKey: Path to certificate key
  • certHost: Hostname for self-signed certificate

Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 1 out of 6 changed files in this pull request and generated 3 comments.

Files not reviewed (5)
  • src/code-server/devcontainer-feature.json: Language not supported
  • src/code-server/install.sh: Language not supported
  • test/code-server/code-server-cert-host.sh: Language not supported
  • test/code-server/code-server-cert.sh: Language not supported
  • test/code-server/scenarios.json: Language not supported

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewApril 14, 2025 13:21
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, this approach should make the cert flags shell safe even if the names contain spaces or other special chars. 👍🏻

Comment on lines 59 to 60
CERT_FLAGS+=(--cert)
CERT_FLAGS+=("$CERT")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggestion: Alternative way:

Suggested change
CERT_FLAGS+=(--cert)
CERT_FLAGS+=("$CERT")
CERT_FLAGS+=(--cert"$CERT")

@DanielleMaywoodDanielleMaywood merged commitd719798 intomainApr 14, 2025
7 checks passed
@DanielleMaywoodDanielleMaywood deleted the dm-add-cert-options branchApril 14, 2025 18:29
@DanielleMaywoodDanielleMaywood self-assigned thisApr 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@mafredrimafredrimafredri approved these changes

@defelmnqdefelmnqAwaiting requested review from defelmnq

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DanielleMaywood@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp