- Notifications
You must be signed in to change notification settings - Fork1
feat: add--disable-* options#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add all the '--disable-*' CLI flags as options.
599271d to6067463CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 1 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (11)
- src/code-server/devcontainer-feature.json: Language not supported
- src/code-server/install.sh: Language not supported
- test/code-server/code-server-disable-file-downloads.sh: Language not supported
- test/code-server/code-server-disable-file-uploads.sh: Language not supported
- test/code-server/code-server-disable-getting-started-override.sh: Language not supported
- test/code-server/code-server-disable-multiple-options.sh: Language not supported
- test/code-server/code-server-disable-proxy.sh: Language not supported
- test/code-server/code-server-disable-telemetry.sh: Language not supported
- test/code-server/code-server-disable-update-check.sh: Language not supported
- test/code-server/code-server-disable-workspace-trust.sh: Language not supported
- test/code-server/scenarios.json: Language not supported
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Small suggestion but otherwise LGTM.
| @@ -23,12 +23,42 @@ if [[ -n $WORKSPACE ]]; then | |||
| CODE_SERVER_WORKSPACE="$WORKSPACE" | |||
| fi | |||
| DISABLE_FLAGS="" | |||
| if [[ "$DISABLEFILEDOWNLOADS" == "true" ]]; then | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Haha, couldn't they have_'d these? 😅
src/code-server/install.sh Outdated
| @@ -23,12 +23,42 @@ if [[ -n $WORKSPACE ]]; then | |||
| CODE_SERVER_WORKSPACE="$WORKSPACE" | |||
| fi | |||
| DISABLE_FLAGS="" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggestions: using arrays would be slightly cleaner.
args=()args+=(--disable-file-downloads)args+=(--disable-file-uploads)# ...cmd "${args[*]}"(Note the use of* vs@ due to how we're creating the entry point, so this does not make it shell-safe when there are spaces in any inputs.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, a way to make it shell safe would be:
cat > /usr/local/bin/code-server-entrypoint <<EOF$(declare -p args)cmd "\${args[@]}"EOF😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we do that second approach do we lose the ability to test the entrypoint for containing certain flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Both approaches I outlined should be fine for the test. But in the latter you can't testcoder-server.*--flag, but you can test"--flag" individually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah I understand the second approach more now, I'm happy to do that one 👍
0825e4c intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds several new configuration options to the code-server devcontainer feature that allow users to disable specific functionality:
disableFileDownloads: Prevents users from downloading files from the editordisableFileUploads: Prevents users from uploading files to the editordisableGettingStartedOverride: Disables the coder/coder override in Help: Getting StarteddisableProxy: Disables domain and path proxy routesdisableTelemetry: Disables telemetry reportingdisableUpdateCheck: Disables the update check that runs every 6 hoursdisableWorkspaceTrust: Disables the Workspace Trust feature for the current session