- Notifications
You must be signed in to change notification settings - Fork1
feat: addpasswordFile,hashedPasswordFile,githubAuthTokenFile andabsProxyBasePath options#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR introduces two new configuration options for code-server to improve security by using external password files instead of hardcoded values.
- Adds the hashedPasswordFile option, which uses an Argon2-hashed password that takes priority over passwordFile.
- Adds the passwordFile option to allow direct password authentication via a file.
Files not reviewed (7)
- src/code-server/devcontainer-feature.json: Language not supported
- src/code-server/install.sh: Language not supported
- test/code-server/code-server-hashed-password-file.sh: Language not supported
- test/code-server/code-server-hashed-password-file/Dockerfile: Language not supported
- test/code-server/code-server-password-file.sh: Language not supported
- test/code-server/code-server-password-file/Dockerfile: Language not supported
- test/code-server/scenarios.json: Language not supported
passwordFile andhashedPasswordFile optionspasswordFile,hashedPasswordFile,githubAuthTokenFile andabsProxyBasePath optionssrc/code-server/install.sh Outdated
| if [[ -f "$PASSWORDFILE" ]]; then | ||
| export PASSWORD="\$(cat '$PASSWORDFILE')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| if [[-f"$PASSWORDFILE" ]];then | |
| export PASSWORD="\$(cat '$PASSWORDFILE')" | |
| export PASSWORD="\$(<"$PASSWORDFILE")" |
Minor:useless use of cat 😄 and" is fine within$().
We don't have the same shell safety for inputs here (as withdeclare -p) but arguably if someone passes a file name with" in it then they might have other problems too.
8772e2b intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#462
Adds the final four options
passwordFilehashedPasswordFilegithubAuthTokenFileabsProxyBasePathThe decision to pass credentials via a file instead of embedding them directly in the
devcontainer.jsonis to allow people the ability to not commit the password to source control.With these final four options added we should have feature parity with the CLI.