Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/deploy-code-serverPublic template

Add deploy cli [WIP]#59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 14 commits intomainfromadd-cli
Aug 24, 2021
Merged

Add deploy cli [WIP]#59

BrunoQuaresma merged 14 commits intomainfromadd-cli
Aug 24, 2021

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedAug 19, 2021
edited
Loading

After talking with@bpmct about how we could make code-server easier to install for our users, I came up with the idea to create a CLI for code-server. My first idea is to implement adeploy command likecode-server deploy. I made a POC, and here is the DEMO video if you are interested. I would love to hear your feedback and thoughts.
https://www.loom.com/share/b29513055f874db8a6e41bbf94455d71

What needs to be done:

  • Add the build script pos install
  • Improve the copy if it is needed
  • Add some automated tests, at least on the basic functionalities
  • Add Prettier and ESLint

bpmct and jsjoeio reacted with eyes emoji
@bpmct
Copy link
Member

Add the build script pos install

What do you mean by this? Like another script to run after it is installed?

Improve the copy if it is needed

I think providing a link to generate a DigitalOcean Token (https://cloud.digitalocean.com/account/api/tokens) or we can even shorten, would help.

@bpmct
Copy link
Member

I'd love to ship something like this and write a blog post on it. Being able to customize the server name and region would also be 👌🏼

I'm happy to explore this, commander is an awesome library :)

jsjoeio reacted with heart emoji

@bpmct
Copy link
Member

bpmct commentedAug 23, 2021
edited
Loading

I also noticed this just hangs for me... Any idea why?

Screen Shot 2021-08-23 at 10 03 29 AM

@BrunoQuaresma
Copy link
CollaboratorAuthor

BrunoQuaresma commentedAug 23, 2021
edited
Loading

What do you mean by this? Like another script to run after it is installed?

  • Yes, so we don't have to commit and push the build files.

I think providing a link to generate a DigitalOcean Token

  • Definitely, it is a good thing

I also noticed this just hangs for me... Any idea why?

  • It is happening because the actions are async. we have to check how to fix that 🤔

I'm happy to explore this

  • Feel free to make the changes that you want. I can also help with that
bpmct reacted with thumbs up emoji

Copy link
Contributor

@jsjoeiojsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work@BrunoQuaresma 👏

A couple nits, but all non-blocking

BrunoQuaresma reacted with heart emoji
## Development

```console
git clone git@github.com:cdr/deploy-code-server.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: Is it standard to use the SSH URL instead of HTTPS? I feel like HTTPS is more common, at least from what I see in OSS.

@@ -0,0 +1,14 @@
# dcs-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: not super obvious whatdcs stands for. maybe we should spell it out below "Deploy code-server (dcs)"

@BrunoQuaresmaBrunoQuaresma marked this pull request as ready for reviewAugust 24, 2021 13:28
@BrunoQuaresma
Copy link
CollaboratorAuthor

@bpmct@jsjoeio I publish it to test the release process, and you can run it onnpx:

npx @coder/deploy-code-server

I think we can add the following features for a0.2.0 version of the CLI:

  • Option to chose the region
  • Option to chose the machine type
  • Import the SSH key

Thoughts?

jsjoeio reacted with heart emoji

@jsjoeio
Copy link
Contributor

@bpmct@jsjoeio I publish it to test the release process, and you can run it onnpx:

npx @coder/deploy-code-server

I think we can add the following features for a0.2.0 version of the CLI:

  • Option to chose the region
  • Option to chose the machine type
  • Import the SSH key

Thoughts?

Amazing! Dude you shipped that so quick 🔥 I'll remember to share this with the next code-server release!

Those features for0.2.0 sound great to me! I imagine they're nottoo difficult.

bpmct reacted with thumbs up emojiBrunoQuaresma reacted with heart emojiBrunoQuaresma reacted with rocket emoji

@BrunoQuaresmaBrunoQuaresma merged commit0cedc14 intomainAug 24, 2021
@BrunoQuaresmaBrunoQuaresma deleted the add-cli branchAugust 24, 2021 18:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jsjoeiojsjoeiojsjoeio approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@bpmct@jsjoeio

[8]ページ先頭

©2009-2025 Movatter.jp