- Notifications
You must be signed in to change notification settings - Fork18
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ff685cb to318e09eCompare| cmd := exec.Command( | ||
| "sh", "-c", | ||
| fmt.Sprintf("cd ../../ && go build -o %s ./cmd/coder", path), | ||
| fmt.Sprintf( | ||
| "cd ../../ && mkdir -p %s && ./ci/steps/build.sh && cp ./ci/bin/%s %s/ && tar -xzf %s -C %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What if you just pulled the go build command into its own function and source it so you can call it? Would remove the step of tar -> untar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd prefer it to use as close to the actual release artifact as possible. Maybe that's not particularly rational in this case but the aim of this test is to prevent the previous regression from going undetected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense
Uh oh!
There was an error while loading.Please reload this page.
Related:https://slab.coder.com/posts/regression-report-1-sr2qmy80