Do you prefer v2 or v1 urfave@cmoog?

From looking that the migration docs it just seems like they made envs accept a slice and made most of the command/flag structs pointers instead.

It looks like they enforce that flags are positioned before arguments too. Definetly not a fan of that. For example, the following is invalid.

coder secrets create newsecret --from-literal 123

In v2, this must be

coder secrets create --from-literal 123 newsecret

Yea that straight sucks :(

Yeah for sure, going to revert the migration cause that's super annoying.

I’d be in favour of using cobra then.

Nevermind, I think the flag-before-arg is fine given that thehelp template accurately reflects that and we'll show plenty of example usages in the documentation.

From a UX perspective it's super annoying imo when I'm editing a CLI command. Any context on why they made this change?

@nhooyrhttps://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md#flags-before-args

In v2 flags must come before args. This is more POSIX-compliant.

That’s so dumb. What does it have to do with POSIX lol.

urfave/cli#1113

@nhooyr@coadler how do you cast your votes?

If you're ok migrating, I'd say we go for cobra instead for UX. But I defer to you.

There are some error handling inconsistencies but nothing too bad that can't be fixed after this merges. Don't want to keep this unmerged much longer as it's blocking feature work.

I'm a little swamped right now, don't think I can give this a good review sorry!

To unblock feature work and prevent a rush before the release date, I'm going to merge this now. Some cleanup PRs will be following in parallel.