This repository was archived by the owner on Aug 30, 2024. It is now read-only.

coder/coder-v1-cliPublic archive

NotificationsYou must be signed in to change notification settings
Fork18
Star71

Devurl crud ops#60

Merged

Russtopia merged 5 commits intoupdate-dev-urls-for-api-changesfromdevurl-CRUD-ops

Jun 29, 2020

Merged

Devurl crud ops#60

Russtopia merged 5 commits intoupdate-dev-urls-for-api-changesfromdevurl-CRUD-ops

Jun 29, 2020

Conversation

Copy link

Russtopia commentedJun 25, 2020•
edited
Loading

This implements the new subcommands proposed in#57

Example Usage

$ ./coder urls russ-env1http://3000-russ-env1-admin.russtopia-rlmfuntoo.dogfood.c8s.io/ 3000 PRIVATE

$ ./coder urls create russ-env1 3001 --access=orgAdding devurl for port 3001$ ./coder urls russ-env1http://3000-russ-env1-admin.russtopia-rlmfuntoo.dogfood.c8s.io/ 3000 PRIVATEhttp://3001-russ-env1-admin.russtopia-rlmfuntoo.dogfood.c8s.io/ 3001 ORG

$ ./coder urls create russ-env1 3002 -a groupInvalid access levelUsage: coder urls create <env name> <port> [--access <level>]create/update a devurl for external accesscoder urls create flags:      -a, --access string   [private | org | authed | public] set devurl access (default "private")

$ ./coder urls del russ-env1 80002020-06-25 09:38:25 FATALNo devurl found for port 8000

$ ./coder urls -hUsage: coder urls <env name>get all development urls for external accessCommands:create  create/update a devurl for external accessdel     delete a devurl

$ ./coder urls create -hUsage: coder urls create <env name> <port> [--access <level>]create/update a devurl for external accesscoder urls create flags:      -a, --access string   [private | org | authed | public] set devurl access (default "private")

$ ./coder help urls delUsage: coder urls del <env name> <port>delete a devurl

$ ./coder urls create russ-env1 99999 -a=publicbad portUsage: coder urls create <env name> <port> [--a access]create/update a devurl for external accesscoder urls create flags:      -a, --access string   [private | org | authed | public] set devurl access (default "private")

Russtopia added4 commits

June 24, 2020 11:41

Improve rsync trouble error messages

9294633

Improve ssync error msgs

eefa329

Merge pull request#58from cdr/rsync-error-msgs

29dde34

Improve rsync error msgs

Merge remote-tracking branch 'origin/master' into devurl-CRUD-ops

6450687

Russtopia requested review fromanthonyshull andammario

June 25, 2020 15:24

Russtopia commented

Jun 25, 2020

View reviewed changes

cmd/coder/sync.go OutdatedShow resolvedHide resolved

Russtopia commented

Jun 25, 2020

View reviewed changes

cmd/coder/sync.go OutdatedShow resolvedHide resolved

Russtopia commented

Jun 25, 2020

View reviewed changes

cmd/coder/urls.goShow resolvedHide resolved

Russtopia commented

Jun 25, 2020

View reviewed changes

cmd/coder/urls.goShow resolvedHide resolved

Russtopia force-pushed thedevurl-CRUD-ops branch frome7d80a4 tob76e49dCompare

June 25, 2020 15:43

wbobeirne suggested changes

Jun 25, 2020

View reviewed changes

cmd/coder/urls.go OutdatedShow resolvedHide resolved

Russtopia linked an issue

Jun 25, 2020

that may beclosed by this pull request

Add create and del subcommands to manage devurls#57

Closed

Russtopia force-pushed thedevurl-CRUD-ops branch fromb76e49d to1051d46Compare

June 25, 2020 16:01

Russtopia commented

Jun 25, 2020

View reviewed changes

cmd/coder/urls.go OutdatedShow resolvedHide resolved

Russtopia force-pushed thedevurl-CRUD-ops branch from1051d46 to6b95234Compare

June 25, 2020 16:31

Russtopia mentioned this pull request

Jun 25, 2020

Rsync error msgs#58

Merged

Russtopia force-pushed thedevurl-CRUD-ops branch from6b95234 to24c98cdCompare

June 25, 2020 18:34

Russtopia commented

Jun 25, 2020

View reviewed changes

cmd/coder/sync.goShow resolvedHide resolved

Russtopia commented

Jun 25, 2020

View reviewed changes

internal/sync/sync.goShow resolvedHide resolved

scsmithr suggested changes

Jun 25, 2020

View reviewed changes

cmd/coder/urls.go OutdatedShow resolvedHide resolved

internal/entclient/request.go OutdatedShow resolvedHide resolved

internal/entclient/url.go OutdatedShow resolvedHide resolved

internal/sync/sync.go OutdatedShow resolvedHide resolved

cmd/coder/main.go OutdatedShow resolvedHide resolved

cmd/coder/urls.go OutdatedShow resolvedHide resolved

wbobeirne approved these changes

Jun 25, 2020

View reviewed changes

Copy link

wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My one request was addressed, ty sir 🙏

Russtopia force-pushed thedevurl-CRUD-ops branch 4 times, most recently from0a79ef7 to22bffe8Compare

June 26, 2020 18:21

Russtopia commented

Jun 26, 2020

View reviewed changes

cmd/coder/urls.go

		Desc: "get all development urls for external access",
		Name: "create",
		Usage: "<env name> <port> [--a access]",
		Desc: "create/update a devurl for external access",
		}

Copy link

Author

RusstopiaJun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I made it just --a, do you want it fully-spelled out ie., --access ?

Copy link

Contributor

scsmithrJun 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer--acess for the flag. If you also want the-a shorthand, we could usefl.StringVarP

Russtopia requested a review fromscsmithr

June 26, 2020 19:09

scsmithr reviewed

Jun 27, 2020

View reviewed changes

Copy link

Contributor

scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very minor comments, feel free to merge when addressed.

cmd/coder/urls.go OutdatedShow resolvedHide resolved

cmd/coder/urls.go

		Desc: "get all development urls for external access",
		Name: "create",
		Usage: "<env name> <port> [--a access]",
		Desc: "create/update a devurl for external access",
		}