Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

feat(cli): compare hotfix version metadata#450

Merged
johnstcn merged 7 commits intomainfromcj/ch17586/compare_cli_metadata
Oct 8, 2021

Conversation

johnstcn
Copy link
Member

This PR allows specifyingcli.N hotfix versions to download.
Also altered the success message to remove redundant information.

Before:

$ ./coder update --version v1.19.0+cli.1                                                                                                                                                                                                                                                                                                                                                                                 info: Current version of coder-cli is "v2.34.5"                                                                                                                                                                                                                                                                                                                                                                           ? Do you want to download version 1.19.0 instead? [y/N] y                                                                                                                                                                                                                                                                                                                                                                info: query github releases                                                                                                                                                                                                                                                                                                                                                                                                 | url: "https://api.github.com/repos/cdr/coder-cli/releases/tags/v1.19.0"                                                                                                                                                                                                                                                                                                                                               info: fetching coder-cli from GitHub releases  | https://github.com/cdr/coder-cli/releases/download/v1.19.0/coder-cli-linux-amd64.tar.gzinfo: updated binary reports "coder version v1.19.0 go1.16.4 linux/amd64"success: Updated coder CLI to version 1.19.0+cli.1

After:

$ ./coder update --version v1.19.0+cli.1info: Current version of coder-cli is "v2.34.5"Do you want to download version 1.19.0++cli.1 instead: yinfo: query github releases  | url: "https://api.github.com/repos/cdr/coder-cli/releases/tags/v1.19.0+cli.1"info: fetching coder-cli from GitHub releases  | https://github.com/cdr/coder-cli/releases/download/v1.19.0%2Bcli.1/coder-cli-linux-amd64.tar.gzinfo: updated binary reports "coder version v1.19.0+cli.1 go1.16.4 linux/amd64"success: Updated coder CLI

@shortcut-integration
Copy link

Copy link
Contributor

@jawnsyjawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@coveralls
Copy link

coveralls commentedOct 8, 2021•
edited
Loading

Pull Request Test Coverage Report forBuild 1320554222

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 47 of47(100.0%) changed or added relevant lines in1 file are covered.
  • 2 unchanged lines in1 file lost coverage.
  • Overall coverage increased (+0.4%) to48.165%
Files with Coverage ReductionNew Missed Lines%
wsnet/dial.go276.78%
TotalsCoverage Status
Change from baseBuild 1313295126:0.4%
Covered Lines:2861
Relevant Lines:5940
💛 -Coveralls

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is really neat

@johnstcnjohnstcn merged commit64a406e intomainOct 8, 2021
@johnstcnjohnstcn deleted the cj/ch17586/compare_cli_metadata branchOctober 8, 2021 17:34
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jawnsyjawnsyjawnsy approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

@deansheatherdeansheatherAwaiting requested review from deansheather

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@coveralls@jawnsy@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp