fix: tolerate leading v in semantic versions from coder version API#449

Merged

johnstcn merged 2 commits intomainfromcj/noissue/semver_nonstrict

Sep 30, 2021

Merged

fix: tolerate leading v in semantic versions from coder version API#449

johnstcn merged 2 commits intomainfromcj/noissue/semver_nonstrict

Sep 30, 2021

Conversation

Copy link

Member

johnstcn commentedSep 30, 2021•
edited
Loading

vX.Y.Z is not tolerated bysemver.StrictNewVersion, but is what we embed into our build metadata.
Replace all existing uses ofNewStrictVersion outside test code with its non-strict equivalentNewVersion.

$ go build -ldflags"-X cdr.dev/coder-cli/internal/version.Version=v12.34.56" ./cmd/coder$ ./coder updateinfo: Current version of coder-cli is"v12.34.56"info: Coder instance at"██████████████████████" reports version"1.21.0-rc.1+738-g20e9135d8-20210929"? Do you want to download version 1.21.0 instead? [y/N] y█info: query github releases| url:"https://api.github.com/repos/cdr/coder-cli/releases/tags/v1.21.0-rc.1"info: fetching coder-cli from GitHub releases| https://github.com/cdr/coder-cli/releases/download/v1.21.0-rc.1/coder-cli-linux-amd64.tar.gzinfo: updated binary reports"coder version v1.21.0-rc.1 go1.16.6 linux/amd64"success: Updated coder CLI to version 1.21.0-rc.1+738-g20e9135d8-20210929

fix: tolerate leading v in semantic versions from coder version API

586003b

johnstcn self-assigned this

Sep 30, 2021

fix: quote reported version strings and only print Major.Minor.Patch

b60088f

Copy link

coveralls commentedSep 30, 2021•
edited
Loading

Pull Request Test Coverage Report forBuild 1290564789

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.