Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

feat: make log file path optional and configurable#423

Merged
jawnsy merged 3 commits intomainfromjawnsy/ch16783/configurable-log-path
Sep 2, 2021

Conversation

jawnsy
Copy link
Contributor

@jawnsyjawnsy commentedSep 2, 2021
edited
Loading

New help output:

$ go run ./cmd/coder/main.go agent start --helpstarts the coder agentUsage:  coder agent start --coder-url=<coder_url> --token=<token> --log-file=<path> [flags]Examples:# start the agent and use CODER_URL and CODER_AGENT_TOKEN env varscoder agent start# start the agent and connect with a specified url and agent tokencoder agent start --coder-url https://my-coder.com --token xxxx-xxxx# start the agent and write a copy of the log to /tmp/coder-agent.log# if the file already exists, it will be truncatedcoder agent start --log-file=/tmp/coder-agent.logFlags:      --coder-url string   coder access url  -h, --help               help for start      --log-file string    write a copy of logs to file      --token string       coder agent tokenGlobal Flags:  -v, --verbose   show verbose output

Log to file:

$ go run ./cmd/coder/main.go agent start --log-file=/tmp/file.log2021-09-02 19:23:22.255 [INFO]  <agent.go:100>  starting wsnet listener {"coder_access_url": "https://master.cdr.dev"}2021-09-02 19:23:22.256 [INFO]  <listen.go:114> connecting to broker    {"broker_url": "wss://master.cdr.dev/api/private/envagent/listen?service_token=6067852b-35c4615f433d6b14ede7d1cb"}2021-09-02 19:23:22.343 [INFO]  <listen.go:136> broker connection established^C2021-09-02 19:23:23.100 [INFO]        <agent.go:106>  closing wsnet listener2021-09-02 19:23:23.101 [INFO]  <listen.go:451> listener closed$ cat /tmp/file.log2021-09-02 19:23:22.255 [INFO]  <agent.go:100>  starting wsnet listener {"coder_access_url": "https://master.cdr.dev"}2021-09-02 19:23:22.256 [INFO]  <listen.go:114> connecting to broker    {"broker_url": "wss://master.cdr.dev/api/private/envagent/listen?service_token=6067852b-35c4615f433d6b14ede7d1cb"}2021-09-02 19:23:22.343 [INFO]  <listen.go:136> broker connection established2021-09-02 19:23:23.100 [INFO]  <agent.go:106>  closing wsnet listener2021-09-02 19:23:23.101 [INFO]  <listen.go:451> listener closed

Permission error:

$  go run ./cmd/coder/main.go agent start --log-file=/tmp/agent.log2021-09-02 19:23:39.338 [WARN]  <agent.go:64>   failed to open log file {"error": "open /tmp/agent.log: permission denied"}2021-09-02 19:23:39.339 [INFO]  <agent.go:100>  starting wsnet listener {"coder_access_url": "https://master.cdr.dev"}2021-09-02 19:23:39.339 [INFO]  <listen.go:114> connecting to broker    {"broker_url": "wss://master.cdr.dev/api/private/envagent/listen?service_token=6067852b-35c4615f433d6b14ede7d1cb"}2021-09-02 19:23:39.423 [INFO]  <listen.go:136> broker connection established^C2021-09-02 19:23:40.226 [INFO]        <agent.go:106>  closing wsnet listener2021-09-02 19:23:40.226 [INFO]  <listen.go:451> listener closedexit status 1

Default behavior (no log):

$ go run ./cmd/coder/main.go agent start 2021-09-02 19:24:39.147 [INFO]  <agent.go:100>  starting wsnet listener {"coder_access_url": "https://master.cdr.dev"}2021-09-02 19:24:39.148 [INFO]  <listen.go:114> connecting to broker    {"broker_url": "wss://master.cdr.dev/api/private/envagent/listen?service_token=6067852b-35c4615f433d6b14ede7d1cb"}2021-09-02 19:24:39.231 [INFO]  <listen.go:136> broker connection established^C2021-09-02 19:24:40.906 [INFO]        <agent.go:106>  closing wsnet listener

@shortcut-integration
Copy link

@jawnsyjawnsy self-assigned thisSep 2, 2021
@jawnsyjawnsy marked this pull request as ready for reviewSeptember 2, 2021 17:41
@coveralls
Copy link

coveralls commentedSep 2, 2021
edited
Loading

Pull Request Test Coverage Report forBuild 1195483293

  • 7 of22(31.82%) changed or added relevant lines in1 file are covered.
  • 6 unchanged lines in1 file lost coverage.
  • Overall coverage decreased (-0.1%) to47.88%

Changes Missing CoverageCovered LinesChanged/Added Lines%
internal/cmd/agent.go72231.82%
Files with Coverage ReductionNew Missed Lines%
wsnet/dial.go677.07%
TotalsCoverage Status
Change from baseBuild 1194900284:-0.1%
Covered Lines:2789
Relevant Lines:5825

💛 -Coveralls

@jawnsyjawnsy merged commit1f35561 intomainSep 2, 2021
@jawnsyjawnsy deleted the jawnsy/ch16783/configurable-log-path branchSeptember 2, 2021 19:31
deansheather pushed a commit that referenced this pull requestSep 8, 2021
deansheather pushed a commit that referenced this pull requestSep 13, 2021
(cherry picked from commit1f35561)(cherry picked from commitc00bebd)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlercoadler approved these changes

Assignees

@jawnsyjawnsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jawnsy@coveralls@coadler@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp