Sep 2, 2021 · Sep 2, 2021 · Sep 2, 2021 · Sep 2, 2021 · Sep 2, 2021 · Sep 2, 2021
diff --git a/internal/cmd/agent.go b/internal/cmd/agent.go
 "net/url"
 "os"
 "os/signal"
 "path/filepath"
 "syscall"

 // We use slog here since agent runs in the background and we can benefit
 coder agent start --coder-url https://my-coder.com --token xxxx-xxxx
 `,
 RunE: func(cmd *cobra.Command, args []string) error {
 var (
 ctx = cmd.Context()
 log = slog.Make(sloghuman.Sink(os.Stderr)).Leveled(slog.LevelDebug)
 )
 ctx := cmd.Context()
 sinks := []slog.Sink{
 sloghuman.Sink(os.Stderr),
 }

 file, err := os.OpenFile(filepath.Join(os.TempDir(), "coder-agent.log"), os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0600)
 if err == nil && file != nil {
 sinks = append(sinks, sloghuman.Sink(file))
 }

 log := slog.Make(sinks...).Leveled(slog.LevelDebug)
 if err != nil {
 log.Info(ctx, "failed to open agent log file", slog.Error(err))
 }
 if coderURL == "" {
 var ok bool
 coderURL, ok = os.LookupEnv("CODER_URL")
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,6 +4,7 @@ import (
		"net/url"
		"os"
		"os/signal"
		"path/filepath"
		"syscall"

		// We use slog here since agent runs in the background and we can benefit
Expand DownExpand Up		@@ -48,10 +49,20 @@ coder agent start
		coder agent start --coder-url https://my-coder.com --token xxxx-xxxx
		`,
		RunE: func(cmd *cobra.Command, args []string) error {
		var (
		ctx = cmd.Context()
		log = slog.Make(sloghuman.Sink(os.Stderr)).Leveled(slog.LevelDebug)
		)
		ctx := cmd.Context()
		sinks := []slog.Sink{
		sloghuman.Sink(os.Stderr),
		}

		file, err := os.OpenFile(filepath.Join(os.TempDir(), "coder-agent.log"), os.O_RDWR\|os.O_CREATE\|os.O_TRUNC, 0600)
Copy link ContributorAuthor jawnsySep 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. it didn't seem like the file we write needs to be hidden, so I made it a not-dotfile Copy link Member deansheatherSep 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should be consistent for the other log files in that case Copy link ContributorAuthor jawnsySep 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Which other log files do we have? I think just a code-server one right? Copy link Member deansheatherSep 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. code-server and envagent, they're in environment_stages.go
		if err == nil && file != nil {
		sinks = append(sinks, sloghuman.Sink(file))
		}

		log := slog.Make(sinks...).Leveled(slog.LevelDebug)
		if err != nil {
		log.Info(ctx, "failed to open agent log file", slog.Error(err))
Copy link Contributor coadlerSep 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should this be an`error` log? Copy link ContributorAuthor jawnsySep 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. maybe, but I don't expect it to happen for coder workspaces and everything would be logged to our console anyways coadler reacted with thumbs up emoji
		}
		if coderURL == "" {
		var ok bool
		coderURL, ok = os.LookupEnv("CODER_URL")
Expand Down