Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

feat: Display error to user when SSHing into offline workspace#411

Merged
kylecarbs merged 3 commits intomasterfromsshoff
Aug 9, 2021

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedAug 9, 2021
edited
Loading

Very fun lil hack to display user output on an SSH connection to offline workspaces.

image

Here's what it looks like from VS Code:

image

@kylecarbskylecarbs requested a review fromjawnsyAugust 9, 2021 07:49
@kylecarbs
Copy link
MemberAuthor

[ch15894]

@shortcut-integration
Copy link

@kylecarbskylecarbs changed the titlefeat: Display error to user when SSH'ing into offline workspacefeat: Display error to user when SSHing into offline workspaceAug 9, 2021
Copy link
Contributor

@jawnsyjawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice! what was the error message before?

Co-authored-by: Jonathan Yu <jonathan@coder.com>
@kylecarbs
Copy link
MemberAuthor

A context deadline exceeded 🤕 It'd attempt to connect and exchange candidates but since a workspace wasn't listening nothing would happen!

@kylecarbskylecarbsenabled auto-merge (squash)August 9, 2021 16:53
@kylecarbskylecarbs merged commit3536869 intomasterAug 9, 2021
@kylecarbskylecarbs deleted the sshoff branchAugust 9, 2021 16:56
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jawnsyjawnsyjawnsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@jawnsy

[8]ページ先頭

©2009-2025 Movatter.jp