Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

Use webrtc for coder sh#408

Merged
Emyrk merged 3 commits intomasterfromstevenmasley/ch15591/webrtc_sh
Aug 12, 2021
Merged

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedAug 3, 2021•
edited
Loading

What this does

Uses webrtc forcoder sh

@shortcut-integration
Copy link

This pull request has been linked toClubhouse Story #15591:coder sh should use new webrtc tunnel.

@EmyrkEmyrk marked this pull request as ready for reviewAugust 3, 2021 17:59
@EmyrkEmyrk requested a review fromf0sselAugust 3, 2021 18:00
@Emyrk
Copy link
MemberAuthor

@deansheather@f0ssel This would likely break any v1 providers. I'm guessing we already released the CLI for the last release so I can merge this yes?

@f0ssel
Copy link
Contributor

f0ssel commentedAug 4, 2021•
edited
Loading

Yup this will be safe for 1.22

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It might be cleaner to move our options into a map. That way, we could use them forconfig-ssh along withcoder sh.

@Emyrk
Copy link
MemberAuthor

@kylecarbs That sort of solves things, but the quoting was also different for the two cases.

A more general solution would nice, I didn't try and tackle that here.

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Try to merge master in first... I changed some stuff up with the options that will conflict here!

Emyrk reacted with thumbs up emoji
@EmyrkEmyrk requested a review fromkylecarbsAugust 12, 2021 03:08
@EmyrkEmyrk merged commitf98e94c intomasterAug 12, 2021
@EmyrkEmyrk deleted the stevenmasley/ch15591/webrtc_sh branchAugust 12, 2021 14:16
johnstcn pushed a commit that referenced this pull requestSep 9, 2021
- Use webrtc tunnel for `coder sh` command
johnstcn added a commit that referenced this pull requestSep 10, 2021
* chore: Use webrtc for coder sh (#408)- Use webrtc tunnel for `coder sh` command* chore(cli): "fix" broken unit testCo-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@f0sself0sself0ssel approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Emyrk@f0ssel@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp