Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

Add logs to wsnet listener#388

Merged
deansheather merged 4 commits intomasterfromdean/ch15087
Jul 20, 2021
Merged

Add logs to wsnet listener#388

deansheather merged 4 commits intomasterfromdean/ch15087
Jul 20, 2021

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedJul 16, 2021
edited
Loading

TODO:

  • Add logger
  • Log:
    • Startup
    • Handshake WS connect
    • Handshake WS stream opened in yamux
    • ICE candidates received (and contents)
    • Sending ICE candidates (and contents)
    • Connection state changes
    • Timeouts/ping failures

@shortcut-integration
Copy link

This pull request has been linked toClubhouse Story #15087: Make "coder agent" log stuff.

@deansheatherdeansheather marked this pull request as ready for reviewJuly 20, 2021 02:32
@deansheatherdeansheather requested review fromkylecarbs andf0ssel and removed request forkylecarbsJuly 20, 2021 02:32
@deansheatherdeansheatherenabled auto-merge (squash)July 20, 2021 02:33
Copy link
Contributor

@f0sself0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we current run the agent with debug enabled? We should if not at least for initial release

@deansheatherdeansheather merged commit4de99d5 intomasterJul 20, 2021
@deansheatherdeansheather deleted the dean/ch15087 branchJuly 20, 2021 16:55
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@f0sself0sself0ssel approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@deansheather@f0ssel

[8]ページ先頭

©2009-2025 Movatter.jp