- Notifications
You must be signed in to change notification settings - Fork18
Warn if coder-cli is not in PATH on Windows#357
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
What's blocking this? Seems like it could be important for the |
@kylecarbs The package I'm using to check if the binary is in path seems to fail when cross-compiled for Windows from within my workspace, but works when I build on my Windows machine. I may just write my own function that does the same thing. |
It works when I remove |
Uh oh!
There was an error while loading.Please reload this page.
| @@ -212,7 +259,7 @@ func makeSSHConfig(binPath, host, userName, workspaceName, privateKeyFilepath st | |||
| host := fmt.Sprintf( | |||
| `Host coder.%s | |||
| HostName coder.%s | |||
| ProxyCommand%s tunnel %s 12213 stdio | |||
| ProxyCommand"%s" tunnel %s 12213 stdio | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do the quotes work on Linux too? Ithought I tried it before...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works on windows, mac and linux from my testing.
This pull request has been linked toClubhouse Story #15394: bug: escape path to coder-cli in .ssh/config. |
Uh oh!
There was an error while loading.Please reload this page.
In Powershell and VS Code, the OpenSSH for Windows
ProxyCommandis expected to be a binary name likecoderor a Windows-like path such asC:\path\to\coder.exe.In Msys2 and Git Bash, the Linux-y OpenSSH expects the
ProxyCommandto be a binary name or a Unix-like path such as/c/path/to/coder.To support both environments simultaneously, the
ProxyCommandmust be set tocoder(or whatever binary name coder-cli has), and we must warn the user if the binary is not in$PATH.[CH-15394]