This repository was archived by the owner on Aug 30, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork18
Add commands for workspace providers#238
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4ecb68f
to489be87
Comparecmoog suggested changesFeb 5, 2021
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
50a42dc
to562619b
Comparecoder-sdk/workspace_providers.go Outdated
} | ||
// DeleteWorkspaceProviderByName deletes a workspace provider entity from the Coder control plane. | ||
func (c *Client) DeleteWorkspaceProviderByName(ctx context.Context, name string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
so forcoder-sdk
we should only be using the unique identifiers for our base methods like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
something like this belongs incoderutil
in my view.
cmoog approved these changesFeb 5, 2021
return xerrors.Errorf("listing workspace providers: %w", err) | ||
} | ||
egroup := clog.LoggedErrGroup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
❤️
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This adds create, list, and delete functionality of workspace providers to coder-cli. The functionality is bare bones in this iteration and will be augmented with more documentation, especially around the provider creation flow, in a future pr.
Status field is empty on the create command until I push my changes in m to add that to the create response.
These commands are hidden for now.