feat: Reveal tokens subcommand#229

Merged

jawnsy merged 1 commit intomasterfromjawnsy/ch6470

Jan 25, 2021

Merged

feat: Reveal tokens subcommand#229

jawnsy merged 1 commit intomasterfromjawnsy/ch6470

Jan 25, 2021

Conversation

Copy link

Contributor

jawnsy commentedJan 25, 2021•
edited
Loading

Mark tokens subcommand as visible
Re-generate Markdown documentation for the commands
Add JSON output for "tokens ls" command, as with "envs ls"
Add integration test cases

Tested the commands:

[coder@jawnsy-m docs]$coder tokens ls -o jsonwarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+351-gb3b505259-20210124  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releases[{"id":"RQAv4Tvhiw","name":"abc","application":true,"user_id":"6006fa81-d49b8c0d52e920fe40f5ca90","last_used":"0001-01-01T00:00:00Z"},{"id":"rAvv33PmmY","name":"","application":false,"user_id":"6006fa81-d49b8c0d52e920fe40f5ca90","last_used":"2021-01-22T21:19:58.65074Z"},{"id":"XTCWEeOvoo","name":"","application":false,"user_id":"6006fa81-d49b8c0d52e920fe40f5ca90","last_used":"2021-01-25T00:13:34.62261Z"},{"id":"vl7pIPT8dX","name":"","application":false,"user_id":"6006fa81-d49b8c0d52e920fe40f5ca90","last_used":"2021-01-25T00:22:36.56265Z"}][coder@jawnsy-m docs]$coder tokens create abcdefwarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+351-gb3b505259-20210124  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releasesOo6zFqfK3t-tvUWLtWQPY5Qrj4s14E1Rq[coder@jawnsy-m docs]$coder tokens lswarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+351-gb3b505259-20210124  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releasesID            Name      Application    UserID                               LastUsedOo6zFqfK3t    abcdef    true           6006fa81-d49b8c0d52e920fe40f5ca90    0001-01-01 00:00:00 +0000 UTCRQAv4Tvhiw    abc       true           6006fa81-d49b8c0d52e920fe40f5ca90    0001-01-01 00:00:00 +0000 UTCrAvv33PmmY              false          6006fa81-d49b8c0d52e920fe40f5ca90    2021-01-22 21:19:58.65074 +0000 UTCXTCWEeOvoo              false          6006fa81-d49b8c0d52e920fe40f5ca90    2021-01-25 00:13:34.62261 +0000 UTCvl7pIPT8dX              false          6006fa81-d49b8c0d52e920fe40f5ca90    2021-01-25 00:22:36.56265 +0000 UTC[coder@jawnsy-m docs]$coder tokens regen Oo6zFqfK3twarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+351-gb3b505259-20210124  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releasesOo6zFqfK3t-r9OHpN1h6BJPhnHWFIYbD3[coder@jawnsy-m docs]$coder tokens rm Oo6zFqfK3twarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+351-gb3b505259-20210124  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releases[coder@jawnsy-m docs]$coder tokens lswarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+351-gb3b505259-20210124  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releasesID            Name    Application    UserID                               LastUsedRQAv4Tvhiw    abc     true           6006fa81-d49b8c0d52e920fe40f5ca90    0001-01-01 00:00:00 +0000 UTCrAvv33PmmY            false          6006fa81-d49b8c0d52e920fe40f5ca90    2021-01-22 21:19:58.65074 +0000 UTCXTCWEeOvoo            false          6006fa81-d49b8c0d52e920fe40f5ca90    2021-01-25 00:13:34.62261 +0000 UTCvl7pIPT8dX            false          6006fa81-d49b8c0d52e920fe40f5ca90    2021-01-25 00:22:36.56265 +0000 UTC

jawnsy requested a review fromcmoog

January 25, 2021 00:36

jawnsy self-assigned this

Jan 25, 2021

Copy link

shortcut-integrationbot commentedJan 25, 2021

This pull request has been linked toClubhouse Story #6470: Reveal (and document)coder tokens.

jawnsy requested review frombpmct,kylecarbs andtychoish

January 25, 2021 00:37

cmoog approved these changes

Jan 25, 2021

View reviewed changes

internal/cmd/tokens.go OutdatedShow resolvedHide resolved

jawnsy force-pushed thejawnsy/ch6470 branch 5 times, most recently from85e7bbe to54c2c42Compare

January 25, 2021 00:59

feat: Reveal tokens subcommand

6274e7d

* Mark tokens subcommand as visible* Re-generate Markdown documentation for the commands* Add JSON output for "tokens ls" command, as with "envs ls"* Add integration test cases

jawnsy force-pushed thejawnsy/ch6470 branch from54c2c42 to6274e7dCompare

January 25, 2021 01:02

bpmct approved these changes

Jan 25, 2021

View reviewed changes

Copy link

Member

bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice!

Copy link

ContributorAuthor

jawnsy commentedJan 25, 2021

@cmoog Something from the above output that I'm a bit unsure about, the tokens listed are partial (only the part before the hyphen), so even though regen changes the key (the latter part changes), thecoder tokens ls output looks the same. I assume this is as designed but figured I should highlight it to you just in case.