fix: Force bash for non-standard flags to exec#226

Merged

jawnsy merged 1 commit intomasterfromjawnsy/ch418

Jan 25, 2021

Merged

fix: Force bash for non-standard flags to exec#226

jawnsy merged 1 commit intomasterfromjawnsy/ch418

Jan 25, 2021

Conversation

Copy link

Contributor

jawnsy commentedJan 24, 2021•
edited
Loading

This addresses a regression introduced by#224. POSIXsh does not define arguments to theexec built-in, resulting in an error when usingexec -a to set the process name (argv[0]).

This change executes/bin/bash instead ofsh, and also changes to useexec -l, which automatically handles the hyphen prefix required to trigger login shell behavior.

This also explicitly runs/bin/sh, aligning the behavior ofcoder sh and the frontend Terminal application.

Tested this using Arch Linux (enterprise-dev image) as well as the base Debian image from DockerHub.

[coder@jawnsy-m coder-cli]$go install ./cmd/coder[coder@jawnsy-m coder-cli]$which coder/home/coder/go/bin/coder[coder@jawnsy-m coder-cli]$coder sh jawnsy-mwarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+340-gd64a44cb3-20210123  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releases[coder@jawnsy-m ~]$shopt login_shelllogin_shell     on[coder@jawnsy-m ~]$exitlogout[coder@jawnsy-m coder-cli]$coder sh jawnsy-debianwarning: version mismatch detected  | Coder CLI version: unknown  | Coder API version: 1.14.0+340-gd64a44cb3-20210123  |  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releasesroot@jawnsy-debian:~#shopt login_shelllogin_shell     onroot@jawnsy-debian:~#exitlogout

fix: Force bash for non-standard flags to exec

62734c3

This addresses a regression introduced by#224. POSIX sh does notdefine arguments to the exec built-in, resulting in an error whenusing 'exec -a' to set the process name (argv[0]).This change executes /bin/bash instead of sh, and also changesto use 'exec -l', which automatically handles the hyphen prefixrequired to trigger login shell behavior.This also explicitly runs /bin/sh, aligning the behavior of"coder sh" and the frontend Terminal application.