Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

Add cvm flag to CLI and fields to coder-sdk#201

Merged
cmoog merged 4 commits intomasterfromcvm-flag
Dec 9, 2020
Merged

Conversation

cmoog
Copy link
Contributor

[ch4260]

@cmoogcmoog requested a review fromkylecarbsDecember 5, 2020 21:20
@cmoog
Copy link
ContributorAuthor

--not-container-vm is pretty bad so please note if you have a better alternative.

@cmoogcmoog requested a review fromfuskovicDecember 5, 2020 21:37
@kylecarbs
Copy link
Member

Thoughts on just--container?

@cmoogcmoog marked this pull request as ready for reviewDecember 6, 2020 04:12
@cmoog
Copy link
ContributorAuthor

cmoog commentedDec 6, 2020•
edited
Loading

Thoughts on just --container?

@kylecarbs
For some reason container feels like a subset of conainter-vm, making it potentially confusing as a negator.

@kylecarbs
Copy link
Member

Fair. Maybe just--container and--vm then?

Honestly--container and--cvm isn't bad either.

@kylecarbs
Copy link
Member

Whats the news here moogman?

@cmoog
Copy link
ContributorAuthor

Thought I would just mull it over. The relationship between--container and--cvm is still confusing to me.

@kylecarbs
Copy link
Member

definitely fair

@cmoogcmoog requested a review fromfuskovicDecember 8, 2020 04:05
@cmoogcmoog merged commit9b94c77 intomasterDec 9, 2020
@cmoogcmoog deleted the cvm-flag branchDecember 9, 2020 00:17
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@fuskovicfuskovicfuskovic approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@cmoog@kylecarbs@fuskovic
[8]ページ先頭
©2009-2025 Movatter.jp