This repository was archived by the owner on Aug 30, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork18
Use environment dictionary in config-ssh ux state call#199
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Context:config-ssh needs to be re-ran when new environments are created.Therefore the existing data structure assumption of cliSSHConfigured asa boolean needs to be udpated to reflect environment identifiers.
Just ran locally ✔️ "ux_state": {"cliSSHConfigured": {"5ea9c439-eb239c3b0587c5e58f78416c":true,"5f149999-4ca3bd666994e2597d70fb61":true,"5fb0114b-91a81de17333a1f4d5819986":true }} |
cmoog approved these changesDec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks solid 👍
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Context
https://github.com/cdr/c/pull/6095#issuecomment-738496271
cliSSHConfiguredis changing data structure frombool->map[string]boolin order to capture which environments are configured for SSH.Progress