Nov 14, 2020 · Nov 14, 2020 · Nov 14, 2020 · Nov 14, 2020
diff --git a/coder-sdk/tags.go b/coder-sdk/tags.go
 Default bool   `json:"default"`
 }

 // SetDefaultTagReq is used to set the default tag for an image.
 type SetDefaultTagReq struct {
 DefaultTag string `json:"default_tag"`
 }

 // CreateImageTag creates a new image tag resource.
 func (c Client) CreateImageTag(ctx context.Context, imageID string, req CreateImageTagReq) (*ImageTag, error) {
 var tag ImageTag
 }
 return &tag, nil
 }

 // SetDefaultImageTag sets the default tag for an image. The tag must exist before calling this method.
 func (c Client) SetDefaultImageTag(ctx context.Context, imageID string, req SetDefaultTagReq) error {
 return c.requestBody(ctx, http.MethodPatch, "/api/images/"+imageID, req, nil)
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,6 +35,11 @@ type CreateImageTagReq struct {
		Default bool `json:"default"`
		}

		// SetDefaultTagReq is used to set the default tag for an image.
		type SetDefaultTagReq struct {
Copy link ContributorAuthor jmcampaniniNov 14, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Another approach is to have the`SetDefaultImageTag` take a`tag string` instead, and then we build the JSON struct either on the fly or build it using an inline struct. I went with this approach since it seemed to mirror the existing struct`CreateImageTagReq`.
		DefaultTag string `json:"default_tag"`
		}

		// CreateImageTag creates a new image tag resource.
		func (c Client) CreateImageTag(ctx context.Context, imageID string, req CreateImageTagReq) (*ImageTag, error) {
		var tag ImageTag
Expand DownExpand Up		@@ -66,3 +71,8 @@ func (c Client) ImageTagByID(ctx context.Context, imageID, tagID string) (*Image
		}
		return &tag, nil
		}

		// SetDefaultImageTag sets the default tag for an image. The tag must exist before calling this method.
		func (c Client) SetDefaultImageTag(ctx context.Context, imageID string, req SetDefaultTagReq) error {
		return c.requestBody(ctx, http.MethodPatch, "/api/images/"+imageID, req, nil)
Copy link ContributorAuthor jmcampaniniNov 14, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This method returns the image, but I don't think that's necessary if you already have the imageID and this method returns without an error - the only changed value would be the default tag field. Copy link Contributor cmoogNov 14, 2020 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Totally agree. Returning an error alone seems appropriate here.
		}