- Notifications
You must be signed in to change notification settings - Fork18
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -35,6 +35,11 @@ type CreateImageTagReq struct { | |||
| Default bool `json:"default"` | |||
| } | |||
| // SetDefaultTagReq is used to set the default tag for an image. | |||
| type SetDefaultTagReq struct { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Another approach is to have theSetDefaultImageTag take atag string instead, and then we build the JSON struct either on the fly or build it using an inline struct.
I went with this approach since it seemed to mirror the existing structCreateImageTagReq.
| // SetDefaultImageTag sets the default tag for an image. The tag must exist before calling this method. | ||
| func (c Client) SetDefaultImageTag(ctx context.Context, imageID string, req SetDefaultTagReq) error { | ||
| return c.requestBody(ctx, http.MethodPatch, "/api/images/"+imageID, req, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This method returns the image, but I don't think that's necessary if you already have the imageID and this method returns without an error - the only changed value would be the default tag field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Totally agree. Returning an error alone seems appropriate here.
Can this functionality be folded under#188 ? We could modify the DefaultTagstring`json:"default_tag"` |
my understanding from the |
Allow the SDK to set the default tag for an image. We have a scenario where we'd like to update the default tag of an image to a pre-existing tag (so we can't use the create call with default=true).