- Notifications
You must be signed in to change notification settings - Fork18
Change coder create | edit envs image flag to take image name and source defaults from image#159
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c823160
to7d89f9e
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
985b877
to58b4d42
CompareIt looks like all the envs commands take pointers because the value of Pushed all yours up as well and I updated the PR description to reflect any new changes and behaviors. |
Uh oh!
There was an error while loading.Please reload this page.
e6daf5c
to1a2a7ce
Compare@@ -68,6 +68,16 @@ func LogSuccess(header string, lines ...string) { | |||
}.String()) | |||
} | |||
// LogWarn prints the given warn message to stderr. | |||
func LogWarn(header string, lines ...string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice 👍
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
// Environment disks can not be shrink so we have to overwrite this | ||
// if the user accidentally requests it or if the default diskGB value for a | ||
// newly requested image is smaller than the current amount the environment is using. | ||
if *updateReq.DiskGB < conf.environment.DiskGB { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice 👍
928f447
toa3dfa5d
Comparecmoog commentedOct 27, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Also- I've been moving towards |
dc19fa2
to9d1ed0d
CompareUh oh!
There was an error while loading.Please reload this page.
… defaults from image
0ee26d4
todee3f7c
Compare
Uh oh!
There was an error while loading.Please reload this page.
What this does
--image
flag instead of having to pass the image id.create
andedit
create
andedit
both now source default resource amounts based on the imported image vs arbitrary ones we had previously defined in the CLI.Create
Create environment with default resource amounts
This screenshot also demonstrates some examples of errors users might have.
Create environment with custom resource amounts
Edit
Change the image of an environment
When an environment image is changed and resource amounts are left unspecified, the resource amounts will be changed to that of the default resource amounts specified by the new image the environment will be using.
Also not there's a caveat here in the screenshot it's worth being aware of. Notice when we are going from
codercom/enterprise-dev
toubuntu
that we get a warning message about how we can't reduce the amount of disk storage. The ubuntu default is 10 so the tool is smart enough to recognize that the default amount of the new image for disk is smaller than what it's currently using and keeps it the same while warning the user.Change the resource amounts of an environment
Change both the image and resource amounts of an environment