Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Aug 30, 2024. It is now read-only.
/coder-v1-cliPublic archive

Add ws dials for resource load and ide status#111

Merged
f0ssel merged 3 commits intomasterfromstress-sdk-2
Sep 4, 2020
Merged

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedSep 4, 2020•
edited
Loading

This blockshttps://github.com/cdr/c/pull/5206

  • Fixes a bug where create environments returned nil always (oops)
  • Adds new dial endpoints that are used for stress testing
  • Adds WaitForEnvironmentReady utility on the sdk client

@f0sself0ssel merged commitac39d3c intomasterSep 4, 2020
@f0sself0ssel deleted the stress-sdk-2 branchSeptember 4, 2020 17:46
}

// WaitForEnvironmentReady will watch the build log and return when done
func (c Client) WaitForEnvironmentReady(ctx context.Context, env *Environment) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why does this need the full environment when the above function doesn't?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, good point.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@coadlercoadlercoadler left review comments

@cmoogcmoogcmoog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@f0ssel@coadler@cmoog
[8]ページ先頭
©2009-2025 Movatter.jp