- Notifications
You must be signed in to change notification settings - Fork18
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wbobeirne commentedAug 31, 2020
Tagging in@creack as both a Go wizard, and a Windows user |
Sounds good. It should be noted that I amdefinitelynot a windows user. |
For the records, I am not either!, But I'll look into it :) |
| @@ -52,11 +52,14 @@ func configSSH(configpath *string, remove *bool) func(cmd *cobra.Command, _ []st | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
| usr, err := user.Current() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That is going to be a problem on some systems and will prevent us from shipping a static binaries.
It has been a while, I'm looking into this to see the extent, it might have improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alright, I didn't see we were using it before already.
I checked and at least in go1.15, it does work without cgo! Which is quite neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tested with and without cgo, and tested on windows, works as expected.
Slight note on windows, the path output has double\.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pushed a fix that resolves the double\ (straight to master by accident 😰 ).
| @@ -52,11 +52,14 @@ func configSSH(configpath *string, remove *bool) func(cmd *cobra.Command, _ []st | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
| usr, err := user.Current() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alright, I didn't see we were using it before already.
I checked and at least in go1.15, it does work without cgo! Which is quite neat.
| @@ -52,11 +52,14 @@ func configSSH(configpath *string, remove *bool) func(cmd *cobra.Command, _ []st | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
| usr, err := user.Current() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tested with and without cgo, and tested on windows, works as expected.
Slight note on windows, the path output has double\.
Closes#102