Commitfa8cbf7

Russtopia

committed

Added proposed edit cmd as synonym for create

Doc comment for regexRemoved error log for devURLS empty list

1 parent99468a5 commitfa8cbf7Copy full SHA for fa8cbf7

File tree

1 file changed

+15

-4

lines changed

cmd/coder
- urls.go

1 file changed

+15

-4

lines changed

`‎cmd/coder/urls.go`

Lines changed: 15 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,17 @@ type createSubCmd struct {`
`58`	`58`	`accessstring`
`59`	`59`	`urlnamestring`
`60`	`60`	`}`
	`61`	`+typeeditSubCmdstruct {`
	`62`	`+createSubCmd`
	`63`	`+}`
	`64`	`+`
	`65`	`+func (sub*editSubCmd)Spec() cli.CommandSpec {`
	`66`	`+return cli.CommandSpec{`
	`67`	`+Name:"edit",`
	`68`	`+Usage:"<env name> <port> [--access <level>] [--name <name>]",`
	`69`	`+Desc:"create/update a devurl for external access",`
	`70`	`+}`
	`71`	`+}`
`61`	`72`
`62`	`73`	`func (subcreateSubCmd)RegisterFlags(flpflag.FlagSet) {`
`63`	`74`	`fl.StringVarP(&sub.access,"access","a","private","[private \| org \| authed \| public] set devurl access")`
`@@ -72,6 +83,9 @@ func (sub createSubCmd) Spec() cli.CommandSpec {`
`72`	`83`	`}`
`73`	`84`	`}`
`74`	`85`
	`86`	`+// devURLNameValidRx is the regex used to validate devurl names specified`
	`87`	`+// via the --name subcommand. Named devurls must begin with a letter, and`
	`88`	`+// consist solely of letters and digits, with a max length of 64 chars.`
`75`	`89`	`vardevURLNameValidRx=regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9]{0,63}$")`
`76`	`90`
`77`	`91`	`// Run creates or updates a devURL, specified by env ID and port`
`@@ -208,10 +222,6 @@ func urlList(envName string) []DevURL {`
`208`	`222`	`flog.Fatal("%v",err)`
`209`	`223`	`}`
`210`	`224`
`211`		`-iflen(devURLs)==0 {`
`212`		`-flog.Error("no dev urls were found for environment: %s",envName)`
`213`		`-}`
`214`		`-`
`215`	`225`	`returndevURLs`
`216`	`226`	`}`
`217`	`227`
`@@ -231,6 +241,7 @@ func (cmd urlsCmd) Run(fl *pflag.FlagSet) {`
`231`	`241`	`func (cmd*urlsCmd)Subcommands() []cli.Command {`
`232`	`242`	`return []cli.Command{`
`233`	`243`	`&createSubCmd{},`
	`244`	`+&editSubCmd{},`
`234`	`245`	`&delSubCmd{},`
`235`	`246`	`}`
`236`	`247`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfa8cbf7

File tree

1 file changed

1 file changed

`‎cmd/coder/urls.go`

0 commit comments