Commit88b6ebc

committed

fixup! fixup! fixup! fixup! Add integration tests for Secrets commands

1 parent42e024e commit88b6ebcCopy full SHA for 88b6ebc

File tree

+11

-3

lines changed

+11

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func TestCoderCLI(t *testing.T) {`
`70`	`70`	`varuser entclient.User`
`71`	`71`	c.Run(ctx,`coder users ls -o json \| jq -c '.[] \| select( .username == "charlie")'`).Assert(t,
`72`	`72`	`tcli.Success(),`
`73`		`-jsonUnmarshals(&user),`
	`73`	`+stdoutUnmarshalsJSON(&user),`
`74`	`74`	`)`
`75`	`75`	`assert.Equal(t,"user email is as expected","charlie@coder.com",user.Email)`
`76`	`76`	`assert.Equal(t,"username is as expected","Charlie",user.Name)`
`@@ -148,7 +148,7 @@ func TestSecrets(t *testing.T) {`
`148`	`148`	`)`
`149`	`149`	`}`
`150`	`150`
`151`		`-funcjsonUnmarshals(targetinterface{}) tcli.Assertion {`
	`151`	`+funcstdoutUnmarshalsJSON(targetinterface{}) tcli.Assertion {`
`152`	`152`	`returnfunc(ttesting.T,rtcli.CommandResult) {`
`153`	`153`	`slog.Helper()`
`154`	`154`	`err:=json.Unmarshal(r.Stdout,target)`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import (`
`6`	`6`	`"os"`
`7`	`7`
`8`	`8`	`"cdr.dev/coder-cli/internal/x/xtabwriter"`
	`9`	`+"cdr.dev/coder-cli/internal/x/xvalidate"`
`9`	`10`	`"github.com/spf13/pflag"`
`10`	`11`
`11`	`12`	`"go.coder.com/cli"`
`@@ -37,6 +38,7 @@ type listCmd struct {`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`func (cmdlistCmd)Run(flpflag.FlagSet) {`
	`41`	`+xvalidate.Validate(cmd)`
`40`	`42`	`entClient:=requireAuth()`
`41`	`43`
`42`	`44`	`users,err:=entClient.Users()`
`@@ -61,7 +63,6 @@ func (cmd listCmd) Run(fl pflag.FlagSet) {`
`61`	`63`	`default:`
`62`	`64`	`exitUsage(fl)`
`63`	`65`	`}`
`64`		`-`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`func (cmdlistCmd)RegisterFlags(flpflag.FlagSet) {`
`@@ -75,3 +76,10 @@ func (cmd *listCmd) Spec() cli.CommandSpec {`
`75`	`76`	`Desc:"list all users",`
`76`	`77`	`}`
`77`	`78`	`}`
	`79`	`+`
	`80`	`+func (cmd*listCmd)Validate() (e []error) {`
	`81`	`+if!(cmd.outputFmt=="json"\|\|cmd.outputFmt=="human") {`
	`82`	+e=append(e,fmt.Errorf(`--output must be "json" or "human"`))
	`83`	`+}`
	`84`	`+returne`
	`85`	`+}`

Comments

(0)