Movatterモバイル変換

Skip to content

This repository was archived by the owner on Aug 30, 2024. It is now read-only.

coder/coder-v1-cliPublic archive

NotificationsYou must be signed in to change notification settings
Fork18
Star71

Commit626e923

cmoog

committed

fixup! Add golintci and fix errors

1 parent18ae0da commit626e923Copy full SHA for 626e923

File tree

8 files changed

+16

-17

lines changed

.golangci.yml
internal
- clog
  - error.go
- cmd

8 files changed

+16

-17

lines changed

`‎.golangci.yml`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,4 @@ linters-settings:`
`13`	`13`	funcs:# Run `go tool vet help printf` to see available settings for `printf` analyzer.
`14`	`14`	`-(cdr.dev/coder-cli/internal/clog).Tipf`
`15`	`15`	`-(cdr.dev/coder-cli/internal/clog).Hintf`
`16`		`- -(cdr.dev/coder-cli/internal/clog).LogDebugf`
`17`	`16`	`-(cdr.dev/coder-cli/internal/clog).Causef`

`‎internal/clog/error.go`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -112,18 +112,18 @@ func Bold(a string) string {`
`112`	`112`	`returncolor.New(color.Bold).Sprint(a)`
`113`	`113`	`}`
`114`	`114`
`115`		`-//Tip formats according to the given format specifier and prepends a bolded "tip: " header.`
`116`		`-funcTip(formatstring,a...interface{})string {`
	`115`	`+//Tipf formats according to the given format specifier and prepends a bolded "tip: " header.`
	`116`	`+funcTipf(formatstring,a...interface{})string {`
`117`	`117`	`returnfmt.Sprintf("%s %s",Bold("tip:"),fmt.Sprintf(format,a...))`
`118`	`118`	`}`
`119`	`119`
`120`		`-//Hint formats according to the given format specifier and prepends a bolded "hint: " header.`
`121`		`-funcHint(formatstring,a...interface{})string {`
	`120`	`+//Hintf formats according to the given format specifier and prepends a bolded "hint: " header.`
	`121`	`+funcHintf(formatstring,a...interface{})string {`
`122`	`122`	`returnfmt.Sprintf("%s %s",Bold("hint:"),fmt.Sprintf(format,a...))`
`123`	`123`	`}`
`124`	`124`
`125`		`-//Cause formats according to the given format specifier and prepends a bolded "cause: " header.`
`126`		`-funcCause(formatstring,a...interface{})string {`
	`125`	`+//Causef formats according to the given format specifier and prepends a bolded "cause: " header.`
	`126`	`+funcCausef(formatstring,a...interface{})string {`
`127`	`127`	`returnfmt.Sprintf("%s %s",Bold("cause:"),fmt.Sprintf(format,a...))`
`128`	`128`	`}`
`129`	`129`

`‎internal/cmd/auth.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ import (`
`14`	`14`
`15`	`15`	`varerrNeedLogin=clog.Fatal(`
`16`	`16`	`"failed to read session credentials",`
`17`		-clog.Hint(`did you run "coder login [https://coder.domain.com]"?`),
	`17`	+clog.Hintf(`did you run "coder login [https://coder.domain.com]"?`),
`18`	`18`	`)`
`19`	`19`
`20`	`20`	`funcnewClient() (*coder.Client,error) {`

`‎internal/cmd/ceapi.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,6 @@ func findEnv(ctx context.Context, client *coder.Client, envName, userEmail strin`
`78`	`78`	`"failed to find environment",`
`79`	`79`	`fmt.Sprintf("environment %q not found in %q",envName,found),`
`80`	`80`	`clog.BlankLine,`
`81`		`-clog.Tip("run\"coder envs ls\" to view your environments"),`
	`81`	`+clog.Tipf("run\"coder envs ls\" to view your environments"),`
`82`	`82`	`)`
`83`	`83`	`}`

`‎internal/cmd/envs.go`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,8 @@ coder envs --user charlie@coder.com ls -o json \`
`117`	`117`	`iferr=client.StopEnvironment(cmd.Context(),env.ID);err!=nil {`
`118`	`118`	`atomic.AddInt32(&fails,1)`
`119`	`119`	`err=clog.Fatal(fmt.Sprintf("stop environment %q",env.Name),`
`120`		`-clog.Cause(err.Error()),clog.BlankLine,`
`121`		`-clog.Hint("current environment status is %q",env.LatestStat.ContainerStatus),`
	`120`	`+clog.Causef(err.Error()),clog.BlankLine,`
	`121`	`+clog.Hintf("current environment status is %q",env.LatestStat.ContainerStatus),`
`122`	`122`	`)`
`123`	`123`	`clog.Log(err)`
`124`	`124`	`returnerr`
`@@ -186,7 +186,7 @@ coder envs create --cpu 4 --disk 100 --memory 8 --image 5f443b16-30652892427b955`
`186`	`186`	`clog.LogSuccess(`
`187`	`187`	`"creating environment...",`
`188`	`188`	`clog.BlankLine,`
`189`		-clog.Tip(`run "coder envs watch-build %q" to trail the build logs`,args[0]),
	`189`	+clog.Tipf(`run "coder envs watch-build %q" to trail the build logs`,args[0]),
`190`	`190`	`)`
`191`	`191`
`192`	`192`	`iffollow {`
`@@ -205,7 +205,7 @@ coder envs create --cpu 4 --disk 100 --memory 8 --image 5f443b16-30652892427b955`
`205`	`205`	`cmd.Flags().IntP("gpus","g",defaultGPUs,"number GPUs an environment should be provisioned with.")`
`206`	`206`	`cmd.Flags().StringVarP(&img,"image","i","","ID of the image to base the environment off of.")`
`207`	`207`	`cmd.Flags().BoolVar(&follow,"follow",false,"follow buildlog after initiating rebuild")`
`208`		`-cmd.MarkFlagRequired("image")`
	`208`	`+_=cmd.MarkFlagRequired("image")`
`209`	`209`	`returncmd`
`210`	`210`	`}`
`211`	`211`
@@ -296,7 +296,7 @@ coder envs edit back-end-env --disk 20`,
`296`	`296`	`clog.LogSuccess(`
`297`	`297`	`"applied changes to the environment, rebuilding...",`
`298`	`298`	`clog.BlankLine,`
`299`		-clog.Tip(`run "coder envs watch-build %q" to trail the build logs`,envName),
	`299`	+clog.Tipf(`run "coder envs watch-build %q" to trail the build logs`,envName),
`300`	`300`	`)`
`301`	`301`	`returnnil`
`302`	`302`	`},`

`‎internal/cmd/rebuild.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -58,7 +58,7 @@ coder envs rebuild backend-env --force`,
`58`	`58`	`}else {`
`59`	`59`	`clog.LogSuccess(`
`60`	`60`	`"successfully started rebuild",`
`61`		`-clog.Tip("run\"coder envs watch-build %s\" to follow the build logs",env.Name),`
	`61`	`+clog.Tipf("run\"coder envs watch-build %s\" to follow the build logs",env.Name),`
`62`	`62`	`)`
`63`	`63`	`}`
`64`	`64`	`returnnil`

`‎internal/cmd/resourcemanager.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ func printResourceTop(writer io.Writer, groups []groupable, labeler envLabeler,`
`214`	`214`	`iflen(userResources)==0 {`
`215`	`215`	`clog.LogInfo(`
`216`	`216`	`"no groups for the given filters exist with active environments",`
`217`		`-clog.Tip("run\"--show-empty\" to see groups with no resources."),`
	`217`	`+clog.Tipf("run\"--show-empty\" to see groups with no resources."),`
`218`	`218`	`)`
`219`	`219`	`}`
`220`	`220`	`returnnil`

`‎internal/cmd/shell.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ func networkErr(client coder.Client, env coder.Environment) error {`
`201`	`201`	`fmt.Sprintf("environment %q is not running",env.Name),`
`202`	`202`	`fmt.Sprintf("its current status is %q",env.LatestStat.ContainerStatus),`
`203`	`203`	`clog.BlankLine,`
`204`		`-clog.Tip("run\"coder envs rebuild %s --follow\" to start the environment",env.Name),`
	`204`	`+clog.Tipf("run\"coder envs rebuild %s --follow\" to start the environment",env.Name),`
`205`	`205`	`)`
`206`	`206`	`}`
`207`	`207`	`returnxerrors.Errorf("network error, is %q online?",env.Name)`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp