Commit4eafe01

authored

feat: show build log timestamps in local time (#241)

The server-sent ISO8601 timestamps are not necessarily in the user'spreferred timezone. This change uses time.Local() to get the time inthe user's local time according to their system settings.

1 parent32fbd7e commit4eafe01Copy full SHA for 4eafe01

File tree

1 file changed

+23

-4

lines changed

internal/cmd
- rebuild.go

1 file changed

+23

-4

lines changed

`‎internal/cmd/rebuild.go`

Lines changed: 23 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,47 +91,66 @@ func trailBuildLogs(ctx context.Context, client *coder.Client, envID string) err`
`91`	`91`	`iferr!=nil {`
`92`	`92`	`returnerr`
`93`	`93`	`}`
	`94`	`+`
`94`	`95`	`vars*spinner.Spinner`
`95`	`96`	`forl:=rangelogs {`
`96`	`97`	`ifl.Err!=nil {`
`97`	`98`	`returnl.Err`
`98`	`99`	`}`
	`100`	`+`
	`101`	`+logTime:=l.BuildLog.Time.Local()`
	`102`	`+msg:=fmt.Sprintf("%s %s",logTime.Format(time.RFC3339),l.BuildLog.Msg)`
	`103`	`+`
`99`	`104`	`switchl.BuildLog.Type {`
`100`	`105`	`casecoder.BuildLogTypeStart:`
`101`	`106`	`// the FE uses this to reset the UI`
`102`	`107`	`// the CLI doesn't need to do anything here given that we only append to the trail`
	`108`	`+`
`103`	`109`	`casecoder.BuildLogTypeStage:`
`104`		`-msg:=fmt.Sprintf("%s %s",l.BuildLog.Time.Format(time.RFC3339),l.BuildLog.Msg)`
`105`	`110`	`if!isTerminal {`
`106`	`111`	`fmt.Println(msg)`
`107`	`112`	`continue`
`108`	`113`	`}`
	`114`	`+`
`109`	`115`	`ifs!=nil {`
`110`	`116`	`s.Stop()`
`111`	`117`	`fmt.Print("\n")`
`112`	`118`	`}`
	`119`	`+`
`113`	`120`	`s=newSpinner()`
`114`	`121`	`s.Suffix=fmt.Sprintf(" -- %s",msg)`
`115`	`122`	`s.FinalMSG=fmt.Sprintf("%s -- %s",check,msg)`
`116`	`123`	`s.Start()`
	`124`	`+`
`117`	`125`	`casecoder.BuildLogTypeSubstage:`
`118`	`126`	`// TODO(@cmoog) add verbose substage printing`
	`127`	`+if!verbose {`
	`128`	`+continue`
	`129`	`+}`
	`130`	`+`
`119`	`131`	`casecoder.BuildLogTypeError:`
`120`		`-errMsg:=color.RedString("\t%s",l.BuildLog.Msg)`
`121`	`132`	`if!isTerminal {`
`122`		`-fmt.Println(errMsg)`
	`133`	`+fmt.Println(msg)`
`123`	`134`	`continue`
`124`	`135`	`}`
	`136`	`+`
`125`	`137`	`ifs!=nil {`
`126`	`138`	`s.FinalMSG=fmt.Sprintf("%s %s",failure,strings.TrimPrefix(s.Suffix," "))`
`127`	`139`	`s.Stop()`
	`140`	`+fmt.Print("\n")`
`128`	`141`	`}`
`129`		`-fmt.Print(errMsg)`
	`142`	`+`
`130`	`143`	`s=newSpinner()`
	`144`	`+s.Suffix=color.RedString(" -- %s",msg)`
	`145`	`+s.FinalMSG=color.RedString("%s -- %s",failure,msg)`
	`146`	`+s.Start()`
	`147`	`+`
`131`	`148`	`casecoder.BuildLogTypeDone:`
`132`	`149`	`ifs!=nil {`
`133`	`150`	`s.Stop()`
	`151`	`+fmt.Print("\n")`
`134`	`152`	`}`
	`153`	`+`
`135`	`154`	`returnnil`
`136`	`155`	`default:`
`137`	`156`	`returnxerrors.Errorf("unknown buildlog type: %s",l.BuildLog.Type)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit4eafe01

File tree

1 file changed

1 file changed

`‎internal/cmd/rebuild.go`

0 commit comments