Commit426b18c

authored

Fix dial tests (#439)

1 parenta778c5f commit426b18cCopy full SHA for 426b18c

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,9 @@ func Dial(ctx context.Context, conn net.Conn, options DialOptions) (Dialer, er`
`178`	`178`
`179`	`179`	`err=dialer.negotiate(ctx)`
`180`	`180`	`iferr!=nil {`
`181`		`-returnnil,xerrors.Errorf("negotiate rtc connection: %w",err)`
	`181`	`+// Return the dialer since we have tests that verify things are closed`
	`182`	`+// if negotiation fails.`
	`183`	`+returndialer,xerrors.Errorf("negotiate rtc connection: %w",err)`
`182`	`184`	`}`
`183`	`185`
`184`	`186`	`returndialer,nil`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,15 @@ func TestDial(t *testing.T) {`
`62`	`62`	`defercancelFunc()`
`63`	`63`	`dialer,err:=DialWebsocket(ctx,connectAddr,nil,nil)`
`64`	`64`	`require.True(t,errors.Is(err,context.DeadlineExceeded))`
	`65`	`+require.NotNil(t,dialer)`
`65`	`66`	`require.Error(t,dialer.conn.Close(),"already wrote close")`
	`67`	`+`
	`68`	`+// Ensure the rtc peer connection is closed. Setting the config options`
	`69`	`+// to empty struct does nothing, but it does fail if the rtc peer conn`
	`70`	`+// is closed.`
	`71`	`+err=dialer.rtc.SetConfiguration(webrtc.Configuration{})`
	`72`	`+require.Error(t,err)`
	`73`	`+require.ErrorIs(t,err,webrtc.ErrConnectionClosed)`
`66`	`74`	`})`
`67`	`75`
`68`	`76`	`t.Run("Ping",func(t*testing.T) {`

Comments

(0)