Commit416d237

authored

Fix version warning parse logic (#172)

1 parent6fd4ea9 commit416d237Copy full SHA for 416d237

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ func VersionsMatch(apiVersion string) bool {`
`13`	`13`	`iflen(withoutPatchRelease)<3 {`
`14`	`14`	`returnfalse`
`15`	`15`	`}`
`16`		`-majorMinor:=strings.Join(withoutPatchRelease[:len(withoutPatchRelease)-1],".")`
	`16`	`+majorMinor:=strings.Join(withoutPatchRelease[:2],".")`
`17`	`17`	`returnstrings.HasPrefix(strings.TrimPrefix(apiVersion,"v"),strings.TrimPrefix(majorMinor,"v"))`
`18`	`18`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,4 +26,8 @@ func TestVersion(t *testing.T) {`
`26`	`26`	`Version="1.15.4"`
`27`	`27`	`match=VersionsMatch("v2.15.2")`
`28`	`28`	`assert.True(t,"versions do not match",!match)`
	`29`	`+`
	`30`	`+Version="1.12.2+cli.rc1"`
	`31`	`+match=VersionsMatch("v1.12.9")`
	`32`	`+assert.True(t,"versions do match",match)`
`29`	`33`	`}`

Comments

(0)