- Notifications
You must be signed in to change notification settings - Fork6
chore: improve release workflow#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This should handle uploading asset to existing release when releases are created manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Consider addingmaybedryrun() from coder'slib.sh to make it easier to test out changes like this.
Uh oh!
There was an error while loading.Please reload this page.
tested script to publishhttps://github.com/coder/coder-logstream-kube/releases/tag/v0.0.11-rc.1 |
| if gh release view $version; then | ||
| echo "Release $version already exists" | ||
| exit 0 | ||
| else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: can remove else case and outdent below block due toexit 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I also discovered that thegh release view is interactive and ensured it could run noninteractively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
cebc951 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR fixes a few things.
rctags are marked as latest. I saw this withv0.0.11-rc.1.gh release create.