- Notifications
You must be signed in to change notification settings - Fork6
Add support for multiple namespaces#107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge2 commits intomainChoose a base branch frommulti-namespace-support
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Allow CODER_NAMESPACE to accept comma-separated list of namespaces- Support watching all namespaces when CODER_NAMESPACE is empty- Automatically use ClusterRole/ClusterRoleBinding for multi-namespace or all-namespace scenarios- Update Helm chart to support both namespace-scoped and cluster-wide RBAC- Add comprehensive documentation for multi-namespace usage- Maintain backward compatibility with single namespace deploymentsFixes#5
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue#5 by adding support for watching pods across multiple namespaces.
Changes
Core Functionality
CODER_NAMESPACE
now accepts comma-separated list of namespacesCODER_NAMESPACE
watches all namespaces cluster-wideRBAC Improvements
rbac.clusterWide
option for manual overrideHelm Chart Updates
namespaces
parameter replacesnamespace
(backward compatible)Documentation
Usage Examples
Single namespace (existing behavior):
helm install coder-logstream-kube coder-logstream-kube/coder-logstream-kube \ --set url=https://coder.example.com \ --set namespaces="coder-workspaces"
Multiple namespaces:
helm install coder-logstream-kube coder-logstream-kube/coder-logstream-kube \ --set url=https://coder.example.com \ --set namespaces="user1,user2,user3"
All namespaces:
helm install coder-logstream-kube coder-logstream-kube/coder-logstream-kube \ --set url=https://coder.example.com \ --set namespaces=""
Testing
Fixes#5