Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for multiple namespaces#107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
blink-so wants to merge2 commits intomain
base:main
Choose a base branch
Loading
frommulti-namespace-support

Conversation

blink-so[bot]
Copy link

@blink-soblink-sobot commentedJun 3, 2025

This PR addresses issue#5 by adding support for watching pods across multiple namespaces.

Changes

Core Functionality

  • Multi-namespace support:CODER_NAMESPACE now accepts comma-separated list of namespaces
  • All-namespace support: EmptyCODER_NAMESPACE watches all namespaces cluster-wide
  • Backward compatibility: Single namespace deployments continue to work unchanged

RBAC Improvements

  • Smart RBAC: Automatically uses ClusterRole/ClusterRoleBinding for multi-namespace scenarios
  • Namespace-scoped: Uses Role/RoleBinding for single namespace deployments
  • Configurable:rbac.clusterWide option for manual override

Helm Chart Updates

  • New values:namespaces parameter replacesnamespace (backward compatible)
  • Automatic detection: Chart determines RBAC scope based on namespace configuration
  • Documentation: Comprehensive examples for all use cases

Documentation

  • Updated README: Clear examples for single, multiple, and all-namespace deployments
  • RBAC guide: Explains permission requirements for different scenarios
  • Migration guide: Smooth transition from single to multi-namespace setups

Usage Examples

Single namespace (existing behavior):

helm install coder-logstream-kube coder-logstream-kube/coder-logstream-kube \    --set url=https://coder.example.com \    --set namespaces="coder-workspaces"

Multiple namespaces:

helm install coder-logstream-kube coder-logstream-kube/coder-logstream-kube \    --set url=https://coder.example.com \    --set namespaces="user1,user2,user3"

All namespaces:

helm install coder-logstream-kube coder-logstream-kube/coder-logstream-kube \    --set url=https://coder.example.com \    --set namespaces=""

Testing

  • Code compiles successfully
  • Maintains backward compatibility
  • Added unit tests for namespace parsing logic

Fixes#5

uvishere reacted with heart emoji
blink-sobot added2 commitsJune 3, 2025 14:31
- Allow CODER_NAMESPACE to accept comma-separated list of namespaces- Support watching all namespaces when CODER_NAMESPACE is empty- Automatically use ClusterRole/ClusterRoleBinding for multi-namespace or all-namespace scenarios- Update Helm chart to support both namespace-scoped and cluster-wide RBAC- Add comprehensive documentation for multi-namespace usage- Maintain backward compatibility with single namespace deploymentsFixes#5
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't limit CODER_NAMESPACE to a single namespace
0 participants

[8]ページ先頭

©2009-2025 Movatter.jp