- Notifications
You must be signed in to change notification settings - Fork2
fix: hostname and proxy command generation#95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+318 −152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- proxy command is configured with the user
- latest Coder versions won't accept the SSH connection if proxy command does not include the workspace owner name- for wildcard configuration the ssh config stays the same but the actual hostname provided to the Toolbox will include the workspace owner name-resolves#94
matifali approved these changesApr 24, 2025
- Coder versions like 2.18.x and before that don't support the wildcard config. In this case, enabling this setting is ignored when generating the ssh config.- however the hostname passed to the Toolbox ssh connection was not taking into account that some versions don't support wildcard config.- this corner case is now covered by encapsulating the hostname resolving logic and taking into account the cli version.
f0ssel approved these changesApr 24, 2025
ccbb835 intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
will include the workspace owner name
For wildcard config:
coder-jetbrains-toolbox-dev.coder.com--*patterncoder-jetbrains-toolbox-dev.coder.com--${ws.ownerName}--${ws.name}.${agent.name}patternFor non wildcard config:
the ssh config hostname follows the
coder-jetbrains-toolbox--${ws.ownerName}--${ws.name}.${agent.name}--dev.coder.compatternthe proxy command will have the username and hostname in the ${ws.ownerName}/${ws.name}.${agent.name} format
the hostname provided to Toolbox follows the
coder-jetbrains-toolbox-dev.coder.com--${ws.ownerName}--${ws.name}.${agent.name}patternresolvesContent unavailable. Try to restart the connection. #94