- Notifications
You must be signed in to change notification settings - Fork4
fix: show login screen when token expires during workspace polling#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
fioan89 commentedApr 11, 2025
- in fact we will now jump to the login screen for any error other than socket timeout because of an OS wake-up
- this patch also contains a re-work of the REST API exception. Coder backend sends very detailed messages with the reason for the http calls to be rejected. We now un-marshall those responses and fill the exception system with better details.
- in fact we will now jump to the login screen for any error other than socket timeout because of an OS wake-up- this patch also contains a re-work of the REST API exception. Coder backend sends very detailed messages with the reason for the http calls to be rejected. We now un-marshall those responses and fill the exception system with better details.
CollaboratorAuthor
fioan89 commentedApr 11, 2025
- forcing the main screen to always show the same exception- this patch refactors the code to accumulate the errors in a buffer and show them when auth screen is visible- in addition, the error reporting uses the Snackbar api which provides greater control, and the possibility to stack errors one on top of each other. This approach simplifies the code on our side even more because the ui page no longer needs to accumulate the errors in a buffer and process them when a notifier is injected by toolbox.
CollaboratorAuthor
fioan89 commentedApr 11, 2025
matifali approved these changesApr 14, 2025
Member
matifali left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks
db3ea7d intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


