Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: show login screen when token expires during workspace polling#83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 2 commits intomainfromfix-go-to-login-screen-when-token-is-expired
Apr 14, 2025

Conversation

@fioan89
Copy link
Collaborator

  • in fact we will now jump to the login screen for any error other than socket timeout because of an OS wake-up
  • this patch also contains a re-work of the REST API exception. Coder backend sends very detailed messages with the reason for the http calls to be rejected. We now un-marshall those responses and fill the exception system with better details.

- in fact we will now jump to the login screen for any error other than socket timeout because of an OS wake-up- this patch also contains a re-work of the REST API exception. Coder backend sends very detailed messages  with the reason for the http calls to be rejected. We now un-marshall those responses and fill the exception  system with better details.
@fioan89
Copy link
CollaboratorAuthor

image

- forcing the main screen to always show the same exception- this patch refactors the code to accumulate the errors in a buffer and show them when auth screen is visible- in addition, the error reporting uses the Snackbar api which provides greater control, and the possibility  to stack errors one on top of each other. This approach simplifies the code on our side even more because  the ui page no longer needs to accumulate the errors in a buffer and process them when a notifier is  injected by toolbox.
@fioan89
Copy link
CollaboratorAuthor

With the second update:
image
image

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks

@fioan89fioan89 merged commitdb3ea7d intomainApr 14, 2025
5 checks passed
@fioan89fioan89 deleted the fix-go-to-login-screen-when-token-is-expired branchApril 14, 2025 09:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matifalimatifalimatifali approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp