Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: go to previous step when connection fails#77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 2 commits intomainfromfix-go-to-previous-step-when-connection-fails
Apr 10, 2025

Conversation

@fioan89
Copy link
Collaborator

  • happens when an error is encountered during connection (like exceptions caused by an expired token)
  • right now the auth wizard stays on the last step.
  • with this changeset the auth steps reset to the initial sign in for auto-connect, or it goes back one step back to the token input step for manual authentication

- happens when an error is encountered during connection (like exceptions caused by an expired token)- right now the auth wizard stays on the last step.- with this changeset the auth steps reset to the initial sign in for auto-connect, or it goes back one step  back to the token input step for manual authentication
@matifali
Copy link
Member

Does this mean we go back to the enter deployment URL screen without pressing the back button?

@fioan89
Copy link
CollaboratorAuthor

Does this mean we go back to the enter deployment URL screen without pressing the back button?

In the case of "auto-login" yes, it jumps back to the initial deployment url and it also shows an error notification. For the manual login sequence, it goes back only one step - to the token page and similarly it shows a notification error.

matifali reacted with thumbs up emoji

@fioan89fioan89 merged commite313f45 intomainApr 10, 2025
5 checks passed
@fioan89fioan89 deleted the fix-go-to-previous-step-when-connection-fails branchApril 10, 2025 18:24
@matifali
Copy link
Member

@fioan89, can you ask for reviews from@f0ssel instead of@bcpeinhardt going forward? Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matifalimatifalimatifali approved these changes

@bcpeinhardtbcpeinhardtAwaiting requested review from bcpeinhardt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fioan89@matifali
[8]ページ先頭
©2009-2025 Movatter.jp