fix: url refresh after log out and log in#67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fioan89 wants to merge2 commits intomainfromfix-url-refresh

Closed

fix: url refresh after log out and log in#67

fioan89 wants to merge2 commits intomainfromfix-url-refresh

Conversation

Copy link

Collaborator

fioan89 commentedApr 3, 2025

the main env header page API is quite limiting, in the sense that the title is never allowed to change. Today we display the Coder URL as the title. However, if the user switches between two deployments via log out and then log in, the URL is never refreshed, leading to a confusing UI (URL is old, while workspaces are from the new deployment)
to workaround the issue we redesigned the page, to have a static string as the page, and bellow the first row, have a link field reflecting the new URL.
resolvesDeployment URL is not refreshed after log out and login to another deployment #66

fix: url refresh after log out and log in

b85e6fe

- the main env header page API is quite limiting, in the sense that the title is never allowed to change.  Today we display the Coder URL as the title. However, if the user switches between two deployments by  logging out and then logging in, the URL is never refreshed, leading to a confusing UI (URL is old,  while workspaces are from the new deployment)- to workaround the issue we redesigned the page, to have a static string as the page, and bellow the first  row, have a link field reflecting the new URL. -resolves#66

fioan89 requested review frommatifali,bpmct andbcpeinhardt

April 3, 2025 22:04

Copy link

CollaboratorAuthor

fioan89 commentedApr 3, 2025

The before vs after:

refactor: explicitly request the main page with URL visible

3f71848

- i.e. with the header page expanded

matifali previously approved these changes

Apr 4, 2025

View reviewed changes

Copy link

Member

matifali commentedApr 4, 2025•
edited
Loading

This doesn't look that good, but it looks like we don't have an option here
I am also fine without making this change, as few people switch between Coder deployments.

We can keep the issue open and wait till ToolBox provides a better way to handle this.

It's safe to label this as anupstream issue, too, given we don't have enough control over it.