Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: override default delete confirmation dialog#61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 4 commits intomainfromfix-delete-confirmation-dialog
Apr 3, 2025

Conversation

fioan89
Copy link
Collaborator

- right now there are two confirmation dialogs when removing a workspace from Toolbox- with this patch we force Toolbox to discard its default dialog and show a custom one with  the Coder titles and messages.
- no longer valid after delete confirmation dialog is using the new api
- workspace status is usually updated every 5 seconds by the polling loop.- that's a bit problematic because when we delete a workspace we have to wait a  couple of seconds until we have some visual feedback.- with this patch we force the workspace status to be in "deleting" if the REST api call  was succesfull.
- right now we depend on the underlying okhttp/moshi marshaller on which order  the workspaces are listed.- instead we can sort them by name and guarantee some consistency
@fioan89fioan89 merged commitb24a324 intomainApr 3, 2025
5 checks passed
@fioan89fioan89 deleted the fix-delete-confirmation-dialog branchApril 3, 2025 07:55
fioan89 added a commit that referenced this pull requestAug 11, 2025
When the plugin is upgraded while JBClient is connected to a remote devserver via the Coder SSH proxy/tunnel, the upgrade process kills andre-establishes the SSH connection. However, JBClient/Toolbox fails todetect the restored connection and reports "Toolbox: Target environmentcom.coder.toolbox:bobiverse-bob.dev not found" error.While digging into the Toolbox bytecode—specifically`ClientOverSshTunnelConnector` — I realized the issue likely stems froman incorrect equals implementation in our custom SSH connection infoobject. In short, when a plugin upgrade terminates the SSH tunnel, theconnector’s monitoring logic correctly detects the lost connection andwaits. But when the SSH connection is re-established, the monitoringlogic fails to recognize it as a valid replacement, because equals isstill using the default `Object#equals` rather than a proper value-basedimplementation.Unfortunately, I wasn’t able to properly test this—specifically,upgrading from a version without the fix to one that includes it—becauseall Toolbox marketplace feeds are signed, preventing us from using atool like mitmproxy to serve a locally modified plugin version. Giventhat, I propose releasing the change first and then performing theupgrade test to confirm the fix.-resolves#61
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@bcpeinhardtbcpeinhardtAwaiting requested review from bcpeinhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are two confirmation dialogs shown when deleting a workspace
2 participants
@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp