- Notifications
You must be signed in to change notification settings - Fork1
fix: override default delete confirmation dialog#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+33 −46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- right now there are two confirmation dialogs when removing a workspace from Toolbox- with this patch we force Toolbox to discard its default dialog and show a custom one with the Coder titles and messages.
- no longer valid after delete confirmation dialog is using the new api
- workspace status is usually updated every 5 seconds by the polling loop.- that's a bit problematic because when we delete a workspace we have to wait a couple of seconds until we have some visual feedback.- with this patch we force the workspace status to be in "deleting" if the REST api call was succesfull.
- right now we depend on the underlying okhttp/moshi marshaller on which order the workspaces are listed.- instead we can sort them by name and guarantee some consistency
matifali approved these changesApr 3, 2025
b24a324
intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
fioan89 added a commit that referenced this pull requestAug 11, 2025
When the plugin is upgraded while JBClient is connected to a remote devserver via the Coder SSH proxy/tunnel, the upgrade process kills andre-establishes the SSH connection. However, JBClient/Toolbox fails todetect the restored connection and reports "Toolbox: Target environmentcom.coder.toolbox:bobiverse-bob.dev not found" error.While digging into the Toolbox bytecode—specifically`ClientOverSshTunnelConnector` — I realized the issue likely stems froman incorrect equals implementation in our custom SSH connection infoobject. In short, when a plugin upgrade terminates the SSH tunnel, theconnector’s monitoring logic correctly detects the lost connection andwaits. But when the SSH connection is re-established, the monitoringlogic fails to recognize it as a valid replacement, because equals isstill using the default `Object#equals` rather than a proper value-basedimplementation.Unfortunately, I wasn’t able to properly test this—specifically,upgrading from a version without the fix to one that includes it—becauseall Toolbox marketplace feeds are signed, preventing us from using atool like mitmproxy to serve a locally modified plugin version. Giventhat, I propose releasing the change first and then performing theupgrade test to confirm the fix.-resolves#61
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right now there are two confirmation dialogs when removing a workspace from Toolbox
with this patch we force Toolbox to discard its default dialog and show a custom one with
the Coder titles and messages.
resolvesThere are two confirmation dialogs shown when deleting a workspace #60