- Notifications
You must be signed in to change notification settings - Fork1
fix: improve ssh config logic when workspaces change#59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- previously, ssh reconfiguration was triggered only when new workspaces were added, and the ssh config was generated only with the additional environments removing the configuration for the previous ones. This means that when a new workspace is created from the web dashboard, the old workspaces are no longer accessible via ssh from Toolbox- now, the logic ensures ssh reconfiguration happens whenever the set of environments changes (including additions or removals), making it more robust, and configuration happens for all valid workspaces.-resolves#14
matifali approved these changesApr 2, 2025
2ce2aa1 intomain 5 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, ssh reconfiguration was triggered only when new workspaces were added, and
the ssh config was generated only with the additional environments removing the configuration
for the previous ones. This means that when a new workspace is created from the web dashboard,
the old workspaces are no longer accessible via ssh from Toolbox
now, the logic ensures ssh reconfiguration happens whenever the set of environments changes
(including additions or removals), making it more robust, and configuration happens for all
valid workspaces.
resolvesCan't connect to an existing and running workspace after a new one was created from the web dashboard #14