Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Impl: update ssh config when settings change#51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 2 commits intomainfromimpl-update-ssh-config-when-settings-change
Mar 29, 2025

Conversation

fioan89
Copy link
Collaborator

  • right now the ssh config is triggered only when at the login and only when new workspaces are
    created. In the last case, the ssh config updates only the new sections.
  • but the user can go into settings page and enable or disable the wildcard ssh config. With this patch
    after the user hits Save, the ssh re-configuration is triggered, without the need to restart Toolbox.

Also a major fix - read only settings acted as snapshots in the sense that they did not reflect any subsequent update to the underlying store because updates create a new readonly instance

  • with this patch we simplified the code even more by exposing a readonly interface with all of the
    implementation in the CoderSettingsStore. PluginSettingsStore and Environments are the only persist-able
    stores.
  • because read only instances share the same settings store instances any update on the writable will reflect
    on the readable instances as well.

matifali reacted with hooray emoji
- they did not reflect any subsequent update because updates create a new backing readonly instance- with this patch we simplified the code even more by exposing a readonly interface with all of the  implementation in the CoderSettingsStore. PluginSettingsStore and Environments are the only persist-able  stores.- because read only instances share the same settings store instances any update on the writable will reflect  on the readable instances as well.
…ings- right now the ssh config is triggered only when at the login and only when new workspaces are  created. In the last case, the ssh config updates only the new sections.- but the user can go into settings page and enable or disable the wildcard ssh config. With this patch  after the user hits Save, the ssh re-configuration is triggered, without the need to restart Toolbox.
@fioan89fioan89 requested a review frommatifaliMarch 28, 2025 23:09
@fioan89fioan89 marked this pull request as ready for reviewMarch 28, 2025 23:09
@matifalimatifali requested a review fromCopilotMarch 29, 2025 00:08
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (9)
  • src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/cli/CoderCLIManager.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/settings/CoderSettings.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/settings/ReadOnlyCoderSettings.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/store/CoderSettingsStore.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/util/TLS.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/views/CoderSettingsPage.kt: Language not supported
  • src/main/kotlin/com/coder/toolbox/views/EnvironmentView.kt: Language not supported

@matifalimatifali requested review fromf0ssel and removed request forbcpeinhardtMarch 29, 2025 00:08
@fioan89fioan89 merged commitda7656f intomainMar 29, 2025
5 checks passed
@fioan89fioan89 deleted the impl-update-ssh-config-when-settings-change branchMarch 29, 2025 00:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@matifalimatifalimatifali approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@fioan89@matifali

[8]ページ先頭

©2009-2025 Movatter.jp