Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

impl: ssh config improvements#41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 21 commits intomainfromssh-config-improvements
Mar 27, 2025
Merged

Conversation

fioan89
Copy link
Collaborator

@fioan89fioan89 commentedMar 21, 2025
edited
Loading

  • different header blocks to differentiate between Gateway and Toolbox ssh config

  • different key for Toolbox for workspace usage

  • honors thedisable autostart setting in the URI handling

  • plugin's display name was changed from Coder Toolbox to Coder

  • adds support for ssh wildcard config, configurable from plugin's Settings page.

  • the settings models were reworked because there was too much confusion around CoderSettings, CoderSettingsState, CoderSettingsService. Lots of properties and some models were introduced only to inject data during tests.

  • among other issues, test related properties were leaking in the business code and there was no clear definition
    between the readable and writable interface. With this PR we have CoderSettingsStore exposing read+write, CoderSettings exposing reads + PluginSettingsStore the underlying persistable store.

  • the tests control data via an instance of PluginSettingsStore just like the business code

  • some of the options that did not make sense to be configurable and were only used in the tests were removed:

    • setupCommand
    • ignoreSetupFailures
  • two settings are now also exposed and configurable in the UI (previously only from tests):

    • ssh log dir
    • ssh extra arguments to the proxy command
  • resolvesCoder settings are not taken into account #40

  • resolvesconvert.ssh/config to use wildcard entries #46

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a concern about--usage-app=toolbox, as we will not ba able to track it beforehttps://github.com/coder/coder/issues/16957.
@f0ssel,@bpmct curious for your thoughts here.

@matifalimatifali requested a review fromf0sselMarch 24, 2025 17:10
- instead of the raw interfaces- this prepares the plugin for the next stage where some of the  settings are read by the URI handling component.
… enabled- uri handling always tried to start the workspace if it was stopped.- this commit honors the `disable autostart` setting which should stop  the starting of the workspace automatically when connecting via SSH.- instead user is warned via a pop-up dialog that manual starting is needed
- this patch makes the window visible in uri handling flows when an  error dialog pops-up.
- catches the exception, logs the errors and pops-up an error dialog during URI handling- previously the call failed silently (for example when the workspace is stopped and out of date)
- to pop-up Toolbox window when it's not showing.
- too much confusion around CoderSettings, CoderSettingsState, CoderSettingsService- lots of properties and some models were introduced only to inject data during tests- test related properties were leaking in the business code and there was no clear definition  between the readable and writable interface- with this commit we have CoderSettingsStore exposing read+write, CoderSettings exposing reads + PluginSettingsStore the underlying persistable store- the tests control data via an instance of PluginSettingsStore just like the business code- two settings are now also exposed and configurable in the UI (previously only from tests):  - ssh log dir  - ssh extra arguments to the proxy command-resolves#40- some of the options that did not make sense to be configurable and were only used in the tests were removed:  - setupCommand  - ignoreSetupFailures- these two are Gateway specific
-resolves#46- it is configurable in the Coder's plugin setting page
- from Coder Toolbox to Coder
- back to jetbrains because there is no tracking support for toolbox, yet.
- use Java's Path to do platform independent path comparison
- slf4j api is now bundled and exposed by Toolbox
- Toolbox calls the Coder environment to get SSH connection information. In this particular case  for wildcard SSH connections the hostname is a bit different.- this patch computes the correct hostname depending on whether wildcard ssh config is enabled or not.
@fioan89fioan89 marked this pull request as ready for reviewMarch 27, 2025 21:20
@fioan89fioan89 merged commitdf37364 intomainMar 27, 2025
5 checks passed
@fioan89fioan89 deleted the ssh-config-improvements branchMarch 27, 2025 21:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@code-ashercode-ashercode-asher left review comments

@bcpeinhardtbcpeinhardtAwaiting requested review from bcpeinhardt

@f0sself0sselAwaiting requested review from f0ssel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convert.ssh/config to use wildcard entries Coder settings are not taken into account
3 participants
@fioan89@matifali@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp