Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

impl: store last used URL in Toolbox Settings Store#200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 6 commits intomainfromstore-last-used-url-in-settings
Sep 27, 2025

Conversation

fioan89
Copy link
Collaborator

Context: Toolbox can store key/value pairs in two places:

  • a settings store which is backed by a clear text json file per each plugin
  • native keystore for sensitive data

At the same time some of Coder's clients (ex: Netflix) would like to deploy at scale preconfigured settings for Toolbox. Most of the needed settings are part of json backed store except the last used URL.

This PR reworks the code around the last used URL/token and moves the URL in the json backed store, making it easy to configure. At the same time we still support the pair stored in the native keystore for backward compatibility reasons.

Context: Toolbox can store key/value pairs in two places:- a settings store which is backed by a clear text json file per each plugin- native keystore for sensitive dataAt the same time some of Coder's clients (ex: Netflix) would like to deploy atscale preconfigured settings for Toolbox. Most of the needed settings are part ofjson backed store except the last used URL.This PR reworks the code around the last used URL/token and moves the URL in thejson backed store, making it easy to configure. At the same time we still supportthe pair stored in the native keystore for backward compatibility reasons.
After a successful connection to a deployment URL we usedto save the same token associated with two keys:- last-token- and associated with the last urlBut it does not make sense, once we have to URL we can easily resolve the tokenassociated with the URL. In other words this commit removes the ability to read/savea token associated with `last-token` key.
URL stored in the native OS secrets store is now superseded bythe URL stored in the JSON backed settings store.
With a takIf/let pattern. Theoretically you can have two threadsracing - one changing the value of lastDeploymentURL and another\one reading. In our code that should be pretty much impossible.But the compiler can't be sure of that so it throws and error.
@fioan89fioan89 merged commit94b329f intomainSep 27, 2025
6 checks passed
@fioan89fioan89 deleted the store-last-used-url-in-settings branchSeptember 27, 2025 08:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

@f0sself0sselAwaiting requested review from f0ssel

@jcjiangjcjiangAwaiting requested review from jcjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@fioan89@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp